Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 2822073002: [inspector] AsyncStackTrace should always have non-zero context group id (Closed)

Created:
3 years, 8 months ago by kozy
Modified:
3 years, 8 months ago
Reviewers:
dgozman
CC:
v8-reviews_googlegroups.com, devtools-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[inspector] AsyncStackTrace should always have non-zero context group id BUG=v8:6189 R=dgozman@chromium.org Review-Url: https://codereview.chromium.org/2822073002 Cr-Commit-Position: refs/heads/master@{#44733} Committed: https://chromium.googlesource.com/v8/v8/+/c38e88651b68ef8e0be4c51067423f2cd938c157

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M src/inspector/v8-stack-trace-impl.cc View 3 chunks +8 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 9 (3 generated)
kozy
Dmitry, please take a look.
3 years, 8 months ago (2017-04-18 01:32:31 UTC) #1
dgozman
Should the same happen to V8StackTraceImpl?
3 years, 8 months ago (2017-04-18 18:28:19 UTC) #2
kozy
On 2017/04/18 18:28:19, dgozman wrote: > Should the same happen to V8StackTraceImpl? For V8StackTraceImpl we ...
3 years, 8 months ago (2017-04-18 18:29:56 UTC) #3
dgozman
lgtm
3 years, 8 months ago (2017-04-19 19:42:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2822073002/1
3 years, 8 months ago (2017-04-19 20:12:30 UTC) #6
commit-bot: I haz the power
3 years, 8 months ago (2017-04-19 20:36:05 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/c38e88651b68ef8e0be4c51067423f2cd93...

Powered by Google App Engine
This is Rietveld 408576698