DevTools: fix jsdoc_validator bug for default parameter

DevTools: fix jsdoc_validator bug for default parameter

Example of issue:

/**
 * @param {number} paramA
 * @param {number} paramB
 */
Help.someFunction = function(paramA, paramB = 1) { ... }

Error from jsdoc_validator:
Help.js:31: ERROR - No @param JSDoc tag found for parameters: [latestVersion = 1]

BUG=none

Review-Url: https://codereview.chromium.org/2821773002
Cr-Commit-Position: refs/heads/master@{#464970}
Committed: https://chromium.googlesource.com/chromium/src/+/d316682af9334e0be5ea1daab1c601e2f72c5f00

[chenwilliam, 2017-04-14 23:03:04]

Description was changed from

==========
DevTools: fix jsdoc_validator bug for default parameter

BUG=none
==========

to

==========
DevTools: fix jsdoc_validator bug for default parameter

Example of issue:

/**
 * @param {number} paramA
 * @param {number} paramB
 */
Help.someFunction = function(paramA, paramB = 1) { ... }

Error from jsdoc_validator:
Help.js:31: ERROR - No @param JSDoc tag found for parameters: [latestVersion =
1]

BUG=none
==========

[chenwilliam, 2017-04-14 23:03:04]

chenwilliam@chromium.org changed reviewers:
+ pfeldman@chromium.org

[chenwilliam, 2017-04-14 23:03:40]

ptal, @paulirish feature request :)

[pfeldman, 2017-04-17 17:31:08]

On 2017/04/14 23:03:40, chenwilliam wrote:
> ptal, @paulirish feature request :)

Will it check that default value is of type 'number' in this case?

[chenwilliam, 2017-04-17 17:44:26]

On 2017/04/17 17:31:08, pfeldman wrote:
> On 2017/04/14 23:03:40, chenwilliam wrote:
> > ptal, @paulirish feature request :)
> 
> Will it check that default value is of type 'number' in this case?

Yup. Closure type checks the default parameter.

Example of an error from incorrect default parameter:

found   : (boolean|number)
required: (number|undefined)
Help._showReleaseNoteIfNeeded = function(lastSeenVersion, latestVersion = true)
{
                                                          ^^^^^^^^^^^^^^^^^^^^

[pfeldman, 2017-04-17 17:50:52]

lgtm

[chenwilliam, 2017-04-17 17:54:24]

The CQ bit was checked by chenwilliam@chromium.org

[commit-bot: I haz the power, 2017-04-17 17:55:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-17 19:19:01]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1492451664768820, "parent_rev":
"1b89b8d1e13e00b2ec19fcbce8056fd204cb1a0b", "commit_rev":
"d316682af9334e0be5ea1daab1c601e2f72c5f00"}

[commit-bot: I haz the power, 2017-04-17 19:19:36]

Description was changed from

==========
DevTools: fix jsdoc_validator bug for default parameter

Example of issue:

/**
 * @param {number} paramA
 * @param {number} paramB
 */
Help.someFunction = function(paramA, paramB = 1) { ... }

Error from jsdoc_validator:
Help.js:31: ERROR - No @param JSDoc tag found for parameters: [latestVersion =
1]

BUG=none
==========

to

==========
DevTools: fix jsdoc_validator bug for default parameter

Example of issue:

/**
 * @param {number} paramA
 * @param {number} paramB
 */
Help.someFunction = function(paramA, paramB = 1) { ... }

Error from jsdoc_validator:
Help.js:31: ERROR - No @param JSDoc tag found for parameters: [latestVersion =
1]

BUG=none

Review-Url: https://codereview.chromium.org/2821773002
Cr-Commit-Position: refs/heads/master@{#464970}
Committed:
https://chromium.googlesource.com/chromium/src/+/d316682af9334e0be5ea1daab1c6...
==========

[commit-bot: I haz the power, 2017-04-17 19:19:37]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d316682af9334e0be5ea1daab1c6...