Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Unified Diff: third_party/WebKit/Source/devtools/scripts/jsdoc_validator/src/org/chromium/devtools/jsdoc/checks/ContextTrackingValidationCheck.java

Issue 2821773002: DevTools: fix jsdoc_validator bug for default parameter (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/devtools/scripts/jsdoc_validator/jsdoc_validator.jar ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/scripts/jsdoc_validator/src/org/chromium/devtools/jsdoc/checks/ContextTrackingValidationCheck.java
diff --git a/third_party/WebKit/Source/devtools/scripts/jsdoc_validator/src/org/chromium/devtools/jsdoc/checks/ContextTrackingValidationCheck.java b/third_party/WebKit/Source/devtools/scripts/jsdoc_validator/src/org/chromium/devtools/jsdoc/checks/ContextTrackingValidationCheck.java
index 9b3ba7698a5bd79aa8567f4c770339ccbd141dc5..0e42182cfc0b8d750bf3fb01a6924d7350caaec9 100644
--- a/third_party/WebKit/Source/devtools/scripts/jsdoc_validator/src/org/chromium/devtools/jsdoc/checks/ContextTrackingValidationCheck.java
+++ b/third_party/WebKit/Source/devtools/scripts/jsdoc_validator/src/org/chromium/devtools/jsdoc/checks/ContextTrackingValidationCheck.java
@@ -130,7 +130,10 @@ public class ContextTrackingValidationCheck extends ValidationCheck {
Node parametersNode = NodeUtil.getFunctionParameters(functionNode);
for (int i = 0, childCount = parametersNode.getChildCount(); i < childCount; ++i) {
Node paramNode = parametersNode.getChildAtIndex(i);
- String paramName = state.getContext().getNodeText(paramNode);
+ String paramText = state.getContext().getNodeText(paramNode);
+
+ // Handle default parameters (ES6)
+ String paramName = paramText.split("=")[0].trim();
parameterNames.add(paramName);
}
return parameterNames;
« no previous file with comments | « third_party/WebKit/Source/devtools/scripts/jsdoc_validator/jsdoc_validator.jar ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698