Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(447)

Issue 2821633002: Remove WTF::String::DeprecatedUpper() (Closed)

Created:
3 years, 8 months ago by tkent
Modified:
3 years, 8 months ago
Reviewers:
qinmin
CC:
blink-reviews, blink-reviews-html_chromium.org, blink-reviews-layout_chromium.org, chromium-reviews, dglazkov+blink, krit, eae+blinkwatch, eric.carlson_apple.com, feature-media-reviews_chromium.org, fmalita+watch_chromium.org, fs, gyuyoung2, haraken, jchaffraix+rendering, kinuko+watch, kouhei+svg_chromium.org, leviw+renderwatch, mlamouri+watch-blink_chromium.org, pdr+svgwatchlist_chromium.org, pdr+renderingwatchlist_chromium.org, rwlbuis, Stephen Chennney, Srirama, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove WTF::String::DeprecatedUpper() Except MediaDocument.cpp, input strings are ASCII-only. So changing DeprecatedUpper() to UpperASCII() wont't change any behavior. As for MediaDocument, the input string is a translated text. Changing DeprecatedUpper() to UpperUnicode(locale) might improve the result in "tr" and "lt" locale. BUG=627682 Review-Url: https://codereview.chromium.org/2821633002 Cr-Commit-Position: refs/heads/master@{#464695} Committed: https://chromium.googlesource.com/chromium/src/+/5b6458c1403e5cb2d24c8c29b8443ffd3a806e22

Patch Set 1 #

Messages

Total messages: 16 (11 generated)
tkent
qinmin@, would you review this please?
3 years, 8 months ago (2017-04-14 04:05:49 UTC) #9
qinmin
l g t m
3 years, 8 months ago (2017-04-14 06:35:02 UTC) #10
qinmin
On 2017/04/14 06:35:02, qinmin wrote: > l g t m lgtm
3 years, 8 months ago (2017-04-14 06:35:22 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2821633002/1
3 years, 8 months ago (2017-04-14 06:54:24 UTC) #13
commit-bot: I haz the power
3 years, 8 months ago (2017-04-14 07:01:40 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5b6458c1403e5cb2d24c8c29b844...

Powered by Google App Engine
This is Rietveld 408576698