Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Unified Diff: third_party/WebKit/Source/platform/wtf/text/WTFString.h

Issue 2821633002: Remove WTF::String::DeprecatedUpper() (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/wtf/text/WTFString.h
diff --git a/third_party/WebKit/Source/platform/wtf/text/WTFString.h b/third_party/WebKit/Source/platform/wtf/text/WTFString.h
index 87d75f9d7f5075673787586d7d64fd60bb2f5140..2b6cc48829a693a4cbfb1d9205399173503db14b 100644
--- a/third_party/WebKit/Source/platform/wtf/text/WTFString.h
+++ b/third_party/WebKit/Source/platform/wtf/text/WTFString.h
@@ -284,16 +284,18 @@ class WTF_EXPORT String {
String Left(unsigned len) const { return Substring(0, len); }
String Right(unsigned len) const { return Substring(length() - len, len); }
- // Returns a lowercase/uppercase version of the string. These functions might
- // convert non-ASCII characters to ASCII characters. For example,
- // DeprecatedLower() for U+212A is 'k', DeprecatedUpper() for U+017F is 'S'.
- // These functions are rarely used to implement web platform features. See
+ // Returns a lowercase version of the string. This function might convert
+ // non-ASCII characters to ASCII characters. For example, DeprecatedLower()
+ // for U+212A is 'k'.
+ // This function is rarely used to implement web platform features. See
// crbug.com/627682.
- // These functions are deprecated. We should use UpperASCII(), or introduce
- // UpperUnicode(), and should introduce LowerASCII() or LowerUnicode().
+ // This function is deprecated. We should use LowerASCII() or introduce
+ // LowerUnicode().
String DeprecatedLower() const;
- String DeprecatedUpper() const;
+ // |locale_identifier| is case-insensitive, and accepts either of "aa_aa" or
+ // "aa-aa". Empty/null |locale_identifier| indicates locale-independent
+ // Unicode case conversion.
String LowerUnicode(const AtomicString& locale_identifier) const;
String UpperUnicode(const AtomicString& locale_identifier) const;

Powered by Google App Engine
This is Rietveld 408576698