Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 2821573003: MD Settings: Network: WiMax: Enable configure (Closed)

Created:
3 years, 8 months ago by stevenjb
Modified:
3 years, 8 months ago
Reviewers:
afakhry, michaelpg
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Network: WiMax: Enable configure BUG=711591 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2821573003 Cr-Commit-Position: refs/heads/master@{#464814} Committed: https://chromium.googlesource.com/chromium/src/+/c194280c502d5d001fd80fc8b547c5f9057a4bca

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/resources/settings/internet_page/internet_detail_page.js View 1 chunk +2 lines, -2 lines 4 comments Download

Messages

Total messages: 10 (5 generated)
stevenjb
3 years, 8 months ago (2017-04-14 19:59:38 UTC) #3
michaelpg
lgtm lgtm w/ optional options https://codereview.chromium.org/2821573003/diff/1/chrome/browser/resources/settings/internet_page/internet_detail_page.js File chrome/browser/resources/settings/internet_page/internet_detail_page.js (right): https://codereview.chromium.org/2821573003/diff/1/chrome/browser/resources/settings/internet_page/internet_detail_page.js#newcode443 chrome/browser/resources/settings/internet_page/internet_detail_page.js:443: var type = networkProperties.Type; ...
3 years, 8 months ago (2017-04-14 20:45:36 UTC) #4
stevenjb
https://codereview.chromium.org/2821573003/diff/1/chrome/browser/resources/settings/internet_page/internet_detail_page.js File chrome/browser/resources/settings/internet_page/internet_detail_page.js (right): https://codereview.chromium.org/2821573003/diff/1/chrome/browser/resources/settings/internet_page/internet_detail_page.js#newcode443 chrome/browser/resources/settings/internet_page/internet_detail_page.js:443: var type = networkProperties.Type; On 2017/04/14 20:45:36, michaelpg wrote: ...
3 years, 8 months ago (2017-04-14 21:34:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2821573003/1
3 years, 8 months ago (2017-04-14 21:34:49 UTC) #7
commit-bot: I haz the power
3 years, 8 months ago (2017-04-14 22:44:09 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c194280c502d5d001fd80fc8b547...

Powered by Google App Engine
This is Rietveld 408576698