MD Settings: Network: WiMax: Enable configure

MD Settings: Network: WiMax: Enable configure

BUG=711591
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2821573003
Cr-Commit-Position: refs/heads/master@{#464814}
Committed: https://chromium.googlesource.com/chromium/src/+/c194280c502d5d001fd80fc8b547c5f9057a4bca

[stevenjb, 2017-04-14 19:59:01]

Description was changed from

==========
MD Settings: Network: WiMax: Enable configure

BUG=711591
==========

to

==========
MD Settings: Network: WiMax: Enable configure

BUG=711591
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[stevenjb, 2017-04-14 19:59:38]

stevenjb@chromium.org changed reviewers:
+ afakhry@chromium.org, michaelpg@chromium.org

[michaelpg, 2017-04-14 20:45:36]

lgtm

lgtm w/ optional options

https://codereview.chromium.org/2821573003/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/internet_page/internet_detail_page.js
(right):

https://codereview.chromium.org/2821573003/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/internet_page/internet_detail_page.js:443: var
type = networkProperties.Type;
`switch (networkProperties.Type) {...`, maybe?

https://codereview.chromium.org/2821573003/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/internet_page/internet_detail_page.js:444: if
(type == CrOnc.Type.CELLULAR)
// Cellular can't be configured because.....

[stevenjb, 2017-04-14 21:34:25]

https://codereview.chromium.org/2821573003/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/internet_page/internet_detail_page.js
(right):

https://codereview.chromium.org/2821573003/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/internet_page/internet_detail_page.js:443: var
type = networkProperties.Type;
On 2017/04/14 20:45:36, michaelpg wrote:
> `switch (networkProperties.Type) {...`, maybe?

A switch isn't ideal because WI_FI and WI_MAX perform an extra test but then
fall through to the default logic.

https://codereview.chromium.org/2821573003/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/internet_page/internet_detail_page.js:444: if
(type == CrOnc.Type.CELLULAR)
On 2017/04/14 20:45:36, michaelpg wrote:
> // Cellular can't be configured because.....

because... there are no configurable properties? Not much to explain here...

[stevenjb, 2017-04-14 21:34:28]

The CQ bit was checked by stevenjb@chromium.org

[commit-bot: I haz the power, 2017-04-14 21:34:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-14 22:43:16]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1492205668545640, "parent_rev":
"e678aa49f3fbb21132296a1356239c79d8db276a", "commit_rev":
"c194280c502d5d001fd80fc8b547c5f9057a4bca"}

[commit-bot: I haz the power, 2017-04-14 22:44:08]

Description was changed from

==========
MD Settings: Network: WiMax: Enable configure

BUG=711591
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Network: WiMax: Enable configure

BUG=711591
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2821573003
Cr-Commit-Position: refs/heads/master@{#464814}
Committed:
https://chromium.googlesource.com/chromium/src/+/c194280c502d5d001fd80fc8b547...
==========

[commit-bot: I haz the power, 2017-04-14 22:44:09]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c194280c502d5d001fd80fc8b547...