MD Settings: Network: WiMax: Enable configure

chrome/browser/resources/settings/internet_page/internet_detail_page.js

Index: chrome/browser/resources/settings/internet_page/internet_detail_page.js
diff --git a/chrome/browser/resources/settings/internet_page/internet_detail_page.js b/chrome/browser/resources/settings/internet_page/internet_detail_page.js
index a4554161aa1871bf861350401ba40747d82675f8..760db46b12bb8dc04ce4cc261f140da8efee0e0e 100644
--- a/chrome/browser/resources/settings/internet_page/internet_detail_page.js
+++ b/chrome/browser/resources/settings/internet_page/internet_detail_page.js
@@ -441,9 +441,9 @@ Polymer({
     if (this.connectNotAllowed_(networkProperties, globalPolicy))
       return false;
     var type = networkProperties.Type;

[michaelpg, 2017/04/14 20:45:36]

`switch (networkProperties.Type) {...`, maybe?

[stevenjb, 2017/04/14 21:34:25]

A switch isn't ideal because WI_FI and WI_MAX perform an extra test but then
fall through to the default logic.

-    if (type == CrOnc.Type.CELLULAR || type == CrOnc.Type.WI_MAX)
+    if (type == CrOnc.Type.CELLULAR)

[michaelpg, 2017/04/14 20:45:36]

// Cellular can't be configured because.....

[stevenjb, 2017/04/14 21:34:25]

because... there are no configurable properties? Not much to explain here...

       return false;
-    if (type == CrOnc.Type.WI_FI &&
+    if ((type == CrOnc.Type.WI_FI || type == CrOnc.Type.WI_MAX) &&
         networkProperties.ConnectionState !=
             CrOnc.ConnectionState.NOT_CONNECTED) {
       return false;