Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Issue 2821573002: Merge M58: "Don't histogram paint time after ending or seeking." (Closed)

Created:
3 years, 8 months ago by DaleCurtis
Modified:
3 years, 8 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

Merge M58: "Don't histogram paint time after ending or seeking." There will be no further paint if we seek past the end of the video stream or reach end of stream; without this, the next actual play which vends a video frame will trigger the histogram path. Which may be minutes or hours later. BUG=709302 TEST=seek to near end of video, trigger bg opt, observe no bad time. Review-Url: https://codereview.chromium.org/2805683004 Cr-Commit-Position: refs/heads/master@{#463476} (cherry picked from commit 1af3c1a4a85d37eaa0398bb5c115d2349f01c6ef) Review-Url: https://codereview.chromium.org/2821573002 . Cr-Commit-Position: refs/branch-heads/3029@{#701} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/ced09bec389e0a04ff27f49527b25557dae7420f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -5 lines) Patch
M media/blink/webmediaplayer_impl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M media/blink/webmediaplayer_impl.cc View 3 chunks +13 lines, -5 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
DaleCurtis
3 years, 8 months ago (2017-04-13 22:27:45 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ced09bec389e0a04ff27f49527b25557dae7420f.

Powered by Google App Engine
This is Rietveld 408576698