Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 2805683004: Don't histogram paint time after ending or seeking. (Closed)

Created:
3 years, 8 months ago by DaleCurtis
Modified:
3 years, 8 months ago
Reviewers:
whywhat
CC:
apacible+watch_chromium.org, chromium-reviews, erickung+watch_chromium.org, feature-media-reviews_chromium.org, miu+watch_chromium.org, xjz+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't histogram paint time after ending or seeking. There will be no further paint if we seek past the end of the video stream or reach end of stream; without this, the next actual play which vends a video frame will trigger the histogram path. Which may be minutes or hours later. BUG=709302 TEST=seek to near end of video, trigger bg opt, observe no bad time. Review-Url: https://codereview.chromium.org/2805683004 Cr-Commit-Position: refs/heads/master@{#463476} Committed: https://chromium.googlesource.com/chromium/src/+/1af3c1a4a85d37eaa0398bb5c115d2349f01c6ef

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -5 lines) Patch
M media/blink/webmediaplayer_impl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M media/blink/webmediaplayer_impl.cc View 3 chunks +13 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
DaleCurtis
Should fix the EOS issues, but doesn't make the metric any more meaningful for src=.
3 years, 8 months ago (2017-04-07 01:03:58 UTC) #2
whywhat
lgtm
3 years, 8 months ago (2017-04-07 02:15:11 UTC) #3
DaleCurtis
Thanks for review, this may fix some of the pause cases too, but I wasn't ...
3 years, 8 months ago (2017-04-10 22:45:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2805683004/1
3 years, 8 months ago (2017-04-10 22:46:01 UTC) #6
commit-bot: I haz the power
3 years, 8 months ago (2017-04-11 00:54:46 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1af3c1a4a85d37eaa0398bb5c115...

Powered by Google App Engine
This is Rietveld 408576698