Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(888)

Side by Side Diff: chrome/browser/media/webrtc/webrtc_video_quality_browsertest.cc

Issue 2821533002: Disable WebRtcVideoQualityBrowserTest on Mac (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <stddef.h> 5 #include <stddef.h>
6 6
7 #include "base/base64.h" 7 #include "base/base64.h"
8 #include "base/command_line.h" 8 #include "base/command_line.h"
9 #include "base/environment.h" 9 #include "base/environment.h"
10 #include "base/files/file.h" 10 #include "base/files/file.h"
(...skipping 326 matching lines...) Expand 10 before | Expand all | Expand 10 after
337 base::ScopedTempDir temp_working_dir_; 337 base::ScopedTempDir temp_working_dir_;
338 }; 338 };
339 339
340 INSTANTIATE_TEST_CASE_P( 340 INSTANTIATE_TEST_CASE_P(
341 WebRtcVideoQualityBrowserTests, 341 WebRtcVideoQualityBrowserTests,
342 WebRtcVideoQualityBrowserTest, 342 WebRtcVideoQualityBrowserTest,
343 testing::ValuesIn(kVideoConfigurations)); 343 testing::ValuesIn(kVideoConfigurations));
344 344
345 IN_PROC_BROWSER_TEST_P(WebRtcVideoQualityBrowserTest, 345 IN_PROC_BROWSER_TEST_P(WebRtcVideoQualityBrowserTest,
346 MANUAL_TestVideoQualityVp8) { 346 MANUAL_TestVideoQualityVp8) {
347 // Disable these tests until crbug.com/711400 is addressed.
348 #if defined(OS_MACOSX)
349 return;
350 #endif // defined(OS_MACOSX)
347 TestVideoQuality("VP8"); 351 TestVideoQuality("VP8");
348 } 352 }
349 353
350 IN_PROC_BROWSER_TEST_P(WebRtcVideoQualityBrowserTest, 354 IN_PROC_BROWSER_TEST_P(WebRtcVideoQualityBrowserTest,
351 MANUAL_TestVideoQualityVp9) { 355 MANUAL_TestVideoQualityVp9) {
356 // Disable these tests until crbug.com/711400 is addressed.
357 #if defined(OS_MACOSX)
358 return;
359 #endif // defined(OS_MACOSX)
352 TestVideoQuality("VP9"); 360 TestVideoQuality("VP9");
353 } 361 }
354 362
355 #if BUILDFLAG(RTC_USE_H264) 363 #if BUILDFLAG(RTC_USE_H264)
356 364
357 IN_PROC_BROWSER_TEST_P(WebRtcVideoQualityBrowserTest, 365 IN_PROC_BROWSER_TEST_P(WebRtcVideoQualityBrowserTest,
358 MANUAL_TestVideoQualityH264) { 366 MANUAL_TestVideoQualityH264) {
367 // Disable these tests until crbug.com/711400 is addressed.
368 #if defined(OS_MACOSX)
369 return;
370 #endif // defined(OS_MACOSX)
359 // Only run test if run-time feature corresponding to |rtc_use_h264| is on. 371 // Only run test if run-time feature corresponding to |rtc_use_h264| is on.
360 if (!base::FeatureList::IsEnabled(content::kWebRtcH264WithOpenH264FFmpeg)) { 372 if (!base::FeatureList::IsEnabled(content::kWebRtcH264WithOpenH264FFmpeg)) {
361 LOG(WARNING) << "Run-time feature WebRTC-H264WithOpenH264FFmpeg disabled. " 373 LOG(WARNING) << "Run-time feature WebRTC-H264WithOpenH264FFmpeg disabled. "
362 "Skipping WebRtcVideoQualityBrowserTest.MANUAL_TestVideoQualityH264 " 374 "Skipping WebRtcVideoQualityBrowserTest.MANUAL_TestVideoQualityH264 "
363 "(test \"OK\")"; 375 "(test \"OK\")";
364 return; 376 return;
365 } 377 }
366 TestVideoQuality("H264"); 378 TestVideoQuality("H264");
367 } 379 }
368 380
369 #endif // BUILDFLAG(RTC_USE_H264) 381 #endif // BUILDFLAG(RTC_USE_H264)
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698