Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 282153003: [VS Addin] Fix several issues with install script. (Closed)

Created:
6 years, 7 months ago by Sam Clegg
Modified:
6 years, 7 months ago
Reviewers:
binji
CC:
native-client-reviews_googlegroups.com
Visibility:
Public.

Description

[VS Addin] Fix several issues with install script. Fix the --vsuser-path flag. It was attempted to append to a tuble. Don't depend on any one of the vsuser-paths existing, only that at least one of them exists. This allows installation to succeed on platforms that only have one version of VS installed. R=binji@chromium.org Committed: https://code.google.com/p/nativeclient-sdk/source/detail?r=1573

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -4 lines) Patch
M visual_studio/NativeClientVSAddIn/InstallerResources/install.py View 1 3 chunks +10 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Sam Clegg
6 years, 7 months ago (2014-05-15 18:33:43 UTC) #1
binji
lgtm, though I don't see this change: "Don't depend on any one of the vsuser-paths ...
6 years, 7 months ago (2014-05-15 19:05:28 UTC) #2
Sam Clegg
On 2014/05/15 19:05:28, binji wrote: > lgtm, though I don't see this change: > > ...
6 years, 7 months ago (2014-05-15 19:14:04 UTC) #3
binji
cool, lgtm
6 years, 7 months ago (2014-05-15 19:51:19 UTC) #4
Sam Clegg
6 years, 7 months ago (2014-05-15 21:21:48 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r1573 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698