[VS Addin] Fix several issues with install script.

visual_studio/NativeClientVSAddIn/InstallerResources/install.py

 #!/usr/bin/env python
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Copies necessary add-in files into place to install the add-in.
 
 This script will copy the necessary files for the Visual Studio add-in
 to where Visual Studio can find them. It assumes the current directory
 contains the necessary files to copy.
 """
 
 import create_ppapi_platform
 import ctypes
 import os
 import optparse
 import platform
 import shutil
 import sys
 import time
 
 NACL32_PLATFORM = 'NaCl32'
 NACL64_PLATFORM = 'NaCl64'
 NACLARM_PLATFORM = 'NaClARM'
 PNACL_PLATFORM = 'PNaCl'
 NACL_PLATFORM_OLD = 'NaCl'
 PEPPER_PLATFORM = 'PPAPI'
 
-DEFAULT_VS_DIRECTORIES = ('%USERPROFILE%\\My Documents\\Visual Studio 2010',
-                          '%USERPROFILE%\\My Documents\\Visual Studio 2012')
+DEFAULT_VS_DIRECTORIES = ['%USERPROFILE%\\My Documents\\Visual Studio 2010',
+                          '%USERPROFILE%\\My Documents\\Visual Studio 2012']
 
 SCRIPT_DIR = os.path.dirname(os.path.abspath(__file__))
 
 ADDIN_FILES = ['NativeClientVSAddIn.AddIn', 'NativeClientVSAddIn.dll']
 
 options = None
 
 if sys.version_info < (2, 6, 2):
   print "\n\nWARNING: Python version 2.6.2 or greater is required. " \
         "Current version is %s\n\n" % (sys.version_info[:3],)
@@ skipping 38 matching lines @@
       return False
 
 
 def UninstallAddin(vsuser_path):
   addin_dir = os.path.join(vsuser_path, 'Addins')
   for file_name in ADDIN_FILES:
     UninstallFile(os.path.join(addin_dir, file_name))
 
 
 def InstallAddin(vsuser_path):
-  vsuser_path = os.path.expandvars(vsuser_path)
-
   vsname = os.path.basename(vsuser_path)
   if '2012' in vsname:
     vs_version = '2012'
   elif '2010' in vsname:
     vs_version = '2010'
   else:
      raise InstallError("Unable to determine valid VS version (2010 or 2012) "
                         "from path: %s" % vsuser_path)
 
   # Ensure install directories exist.
@@ skipping 200 matching lines @@
       raise InstallError('Environment Variable NACL_SDK_ROOT is not set')
     if chrome_path is None:
       raise InstallError('Environment Variable CHROME_PATH is not set')
 
   # If uninstalling then redirect to uninstall program.
   if options.uninstall:
     Uninstall()
     print "\nUninstall complete!\n"
     return 0
 
+  # Verify that at least on Visual Studio user path exists, then
+  # filter out any that don't.
+  options.vsuser_path = [os.path.expandvars(p) for p in options.vsuser_path]
+  if not any(os.path.exists(p) for p in options.vsuser_path):
+    raise InstallError('Failed to find any suitable location to install the'
+                       ' Addin. Tried:\n\t' + '\n\t'.join(options.vsuser_path))
+  options.vsuser_path = [p for p in options.vsuser_path if os.path.exists(p)]
+
   try:
     InstallMSBuild()
 
     for vsuser_path in options.vsuser_path:
       InstallAddin(vsuser_path)
   except:
     print "\nException occured! Rolling back install...\n"
     Uninstall()
     raise
   else:
@@ skipping 16 matching lines @@
       print e
       print("The install script failed to write to the files mentioned above")
       if ctypes.windll.shell32.IsUserAnAdmin() != 1:
         print("Please try running as administrator.")
       else:
         print("Please check for any running programs that might "
               "have them locked.")
     else:
       raise
   sys.exit(rtn)