Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Issue 2821453002: [turbofan] Mark Array constructor calls as no-write if possible. (Closed)

Created:
3 years, 8 months ago by Benedikt Meurer
Modified:
3 years, 8 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Mark Array constructor calls as no-write if possible. If the new.target passed to the Array constructor cannot be a Proxy, then we know that the Array constructor cannot trigger any observable side-effects. R=jarin@chromium.org BUG=v8:6262 Review-Url: https://codereview.chromium.org/2821453002 Cr-Commit-Position: refs/heads/master@{#44645} Committed: https://chromium.googlesource.com/v8/v8/+/dc83caa6fbf659a701f2f78033e70802cbd60470

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -4 lines) Patch
M src/compiler/js-create-lowering.cc View 5 chunks +14 lines, -4 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 10 (6 generated)
Benedikt Meurer
3 years, 8 months ago (2017-04-13 13:00:46 UTC) #1
Jarin
lgtm
3 years, 8 months ago (2017-04-13 13:02:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2821453002/1
3 years, 8 months ago (2017-04-13 13:05:13 UTC) #7
commit-bot: I haz the power
3 years, 8 months ago (2017-04-13 13:28:44 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/dc83caa6fbf659a701f2f78033e70802cbd...

Powered by Google App Engine
This is Rietveld 408576698