Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 2821393002: Show DRP promo on second run (Closed)

Created:
3 years, 8 months ago by megjablon
Modified:
3 years, 8 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

Show DRP promo on second run The promo is currently being shown on second run because native initialization can finish before the FRE completes. Therefore the PROMOS_SKIPPED_ON_FIRST_START pref isn't set until the second run, and then the promo is shown on the third. BUG=672954 Review-Url: https://codereview.chromium.org/2824893002 Cr-Commit-Position: refs/heads/master@{#465085} (cherry picked from commit 147bd1eedea8ce66f162faa43535d60137817d91) Review-Url: https://codereview.chromium.org/2821393002 . Cr-Commit-Position: refs/branch-heads/3071@{#37} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/0d436a66fe3ae362aa757fe2fa5a2819c599abb6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -12 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java View 1 chunk +12 lines, -12 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
megjablon
3 years, 8 months ago (2017-04-18 18:42:59 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0d436a66fe3ae362aa757fe2fa5a2819c599abb6 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698