Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(444)

Issue 2824893002: Show DRP promo on second run (Closed)

Created:
3 years, 8 months ago by megjablon
Modified:
3 years, 8 months ago
Reviewers:
Maria
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Show DRP promo on second run The promo is currently being shown on second run because native initialization can finish before the FRE completes. Therefore the PROMOS_SKIPPED_ON_FIRST_START pref isn't set until the second run, and then the promo is shown on the third. BUG=672954 Review-Url: https://codereview.chromium.org/2824893002 Cr-Commit-Position: refs/heads/master@{#465085} Committed: https://chromium.googlesource.com/chromium/src/+/147bd1eedea8ce66f162faa43535d60137817d91

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -12 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java View 1 chunk +12 lines, -12 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
megjablon
PTAL, thanks!
3 years, 8 months ago (2017-04-17 22:19:45 UTC) #3
Maria
lgtm
3 years, 8 months ago (2017-04-18 00:13:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2824893002/20001
3 years, 8 months ago (2017-04-18 00:18:54 UTC) #6
commit-bot: I haz the power
3 years, 8 months ago (2017-04-18 00:59:52 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/147bd1eedea8ce66f162faa43535...

Powered by Google App Engine
This is Rietveld 408576698