Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 2821373002: chromeos: Fix indentation in multi-line ash strings (Closed)

Created:
3 years, 8 months ago by James Cook
Modified:
3 years, 8 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

chromeos: Fix indentation in multi-line ash strings https://codereview.chromium.org/2720293002/ accidentally introduced extra spaces into some multi-line strings in the ash notification tray bubbles, primarily those for caps lock. Remove the extra spaces. Also fix a couple other cases of bad wrapping in strings. BUG=711361 TEST=manually turn on caps lock, see proper indentation Review-Url: https://codereview.chromium.org/2826483002 Cr-Commit-Position: refs/heads/master@{#464966} (cherry picked from commit faf4c1d6b393e0d8e0b15d970d23294f0b7aa8b5) Review-Url: https://codereview.chromium.org/2821373002 . Cr-Commit-Position: refs/branch-heads/3071@{#36} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/d562c1288d0f63e5c946204f1530ebf594e7b625

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -10 lines) Patch
M ash/ash_strings.grd View 2 chunks +7 lines, -10 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
James Cook
3 years, 8 months ago (2017-04-18 18:11:07 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d562c1288d0f63e5c946204f1530ebf594e7b625.

Powered by Google App Engine
This is Rietveld 408576698