Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 2826483002: chromeos: Fix indentation in multi-line ash strings (Closed)

Created:
3 years, 8 months ago by James Cook
Modified:
3 years, 8 months ago
Reviewers:
afakhry
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

chromeos: Fix indentation in multi-line ash strings https://codereview.chromium.org/2720293002/ accidentally introduced extra spaces into some multi-line strings in the ash notification tray bubbles, primarily those for caps lock. Remove the extra spaces. Also fix a couple other cases of bad wrapping in strings. BUG=711361 TEST=manually turn on caps lock, see proper indentation Review-Url: https://codereview.chromium.org/2826483002 Cr-Commit-Position: refs/heads/master@{#464966} Committed: https://chromium.googlesource.com/chromium/src/+/faf4c1d6b393e0d8e0b15d970d23294f0b7aa8b5

Patch Set 1 #

Patch Set 2 : fingerprint strings #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -10 lines) Patch
M ash/ash_strings.grd View 1 2 chunks +7 lines, -10 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
James Cook
afakhry, please take a look. Feel free to CQ if it looks good to you. ...
3 years, 8 months ago (2017-04-17 17:21:40 UTC) #5
afakhry
lgtm
3 years, 8 months ago (2017-04-17 18:21:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2826483002/20001
3 years, 8 months ago (2017-04-17 19:05:19 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-17 19:11:20 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/faf4c1d6b393e0d8e0b15d970d23...

Powered by Google App Engine
This is Rietveld 408576698