Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2821283003:
[MD settings] avoid dialog resizing in add exception (Closed)
|
Created:
3 years, 8 months ago by dschuyler Modified:
3 years, 8 months ago Reviewers:
Dan Beam CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
Description[MD settings] avoid dialog resizing in add exception
This CL adds a container around the incognito checkbox that doesn't
change size. This allows the incognito checkbox to hide/show without
causing the dialog to resize.
BUG=708078
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2821283003
Cr-Commit-Position: refs/heads/master@{#465761}
Committed: https://chromium.googlesource.com/chromium/src/+/d07818d9b4ba24f750c132cb09153d8ec2701882
Patch Set 1 : typo #
Total comments: 2
Patch Set 2 : visibility: hidden #Messages
Total messages: 22 (16 generated)
Description was changed from ========== [MD settings] avoid dialog resizing in add exception This CL adds a container around the incognito checkbox that doesn't change size. This allows the incognito checkbox to hide/show without causing the dialog to resize. BUG=708078 ========== to ========== [MD settings] avoid dialog resizing in add exception This CL adds a container around the incognito checkbox that doesn't change size. This allows the incognito checkbox to hide/show without causing the dialog to resize. BUG=708078 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run
Patchset #1 (id:1) has been deleted
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
dschuyler@chromium.org changed reviewers: + dbeam@chromium.org
Notes and screen shots in bug.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/2821283003/diff/20001/chrome/browser/resource... File chrome/browser/resources/settings/site_settings/add_site_dialog.html (right): https://codereview.chromium.org/2821283003/diff/20001/chrome/browser/resource... chrome/browser/resources/settings/site_settings/add_site_dialog.html:32: hidden$="[[!showIncognitoSessionOnly_]]"> can you just change hidden$= to using visibility: hidden; in CSS?
The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2821283003/diff/20001/chrome/browser/resource... File chrome/browser/resources/settings/site_settings/add_site_dialog.html (right): https://codereview.chromium.org/2821283003/diff/20001/chrome/browser/resource... chrome/browser/resources/settings/site_settings/add_site_dialog.html:32: hidden$="[[!showIncognitoSessionOnly_]]"> On 2017/04/19 01:20:08, Dan Beam wrote: > can you just change hidden$= to using visibility: hidden; in CSS? Done.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by dschuyler@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1492637197186460,
"parent_rev": "9cf9295d43d7aee7b837e17b185e9cf80958f81e", "commit_rev":
"d07818d9b4ba24f750c132cb09153d8ec2701882"}
Message was sent while issue was closed.
Description was changed from ========== [MD settings] avoid dialog resizing in add exception This CL adds a container around the incognito checkbox that doesn't change size. This allows the incognito checkbox to hide/show without causing the dialog to resize. BUG=708078 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== [MD settings] avoid dialog resizing in add exception This CL adds a container around the incognito checkbox that doesn't change size. This allows the incognito checkbox to hide/show without causing the dialog to resize. BUG=708078 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2821283003 Cr-Commit-Position: refs/heads/master@{#465761} Committed: https://chromium.googlesource.com/chromium/src/+/d07818d9b4ba24f750c132cb0915... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as https://chromium.googlesource.com/chromium/src/+/d07818d9b4ba24f750c132cb0915... |
