Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Side by Side Diff: chrome/browser/resources/settings/site_settings/add_site_dialog.html

Issue 2821283003: [MD settings] avoid dialog resizing in add exception (Closed)
Patch Set: typo Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <link rel="import" href="chrome://resources/cr_elements/cr_dialog/cr_dialog.html "> 1 <link rel="import" href="chrome://resources/cr_elements/cr_dialog/cr_dialog.html ">
2 <link rel="import" href="chrome://resources/html/polymer.html"> 2 <link rel="import" href="chrome://resources/html/polymer.html">
3 <link rel="import" href="chrome://resources/html/web_ui_listener_behavior.html"> 3 <link rel="import" href="chrome://resources/html/web_ui_listener_behavior.html">
4 <link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper-butt on.html"> 4 <link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper-butt on.html">
5 <link rel="import" href="chrome://resources/polymer/v1_0/paper-input/paper-input .html"> 5 <link rel="import" href="chrome://resources/polymer/v1_0/paper-input/paper-input .html">
6 <link rel="import" href="../i18n_setup.html"> 6 <link rel="import" href="../i18n_setup.html">
7 <link rel="import" href="../settings_shared_css.html"> 7 <link rel="import" href="../settings_shared_css.html">
8 <link rel="import" href="constants.html"> 8 <link rel="import" href="constants.html">
9 <link rel="import" href="site_settings_behavior.html"> 9 <link rel="import" href="site_settings_behavior.html">
10 10
11 <dom-module id="add-site-dialog"> 11 <dom-module id="add-site-dialog">
12 <template> 12 <template>
13 <style include="settings-shared"> 13 <style include="settings-shared">
14 #incognito { 14 #incognito {
15 margin-bottom: 2px; 15 margin-bottom: 2px;
16 margin-top: 15px; 16 margin-top: 15px;
17 } 17 }
18
19 #checkboxContainer {
20 min-height: 33px; /* To avoid resizing the dialog. */
21 }
18 </style> 22 </style>
19 <dialog is="cr-dialog" id="dialog" close-text="$i18n{close}"> 23 <dialog is="cr-dialog" id="dialog" close-text="$i18n{close}">
20 <div class="title">$i18n{addSiteTitle}</div> 24 <div class="title">$i18n{addSiteTitle}</div>
21 <div class="body"> 25 <div class="body">
22 <paper-input id="site" always-float-label label="$i18n{addSite}" 26 <paper-input id="site" always-float-label label="$i18n{addSite}"
23 placeholder="$i18n{addSiteExceptionPlaceholder}" 27 placeholder="$i18n{addSiteExceptionPlaceholder}"
24 value="{{site_}}" on-input="validate_" 28 value="{{site_}}" on-input="validate_"
25 error-message="$i18n{notValidWebAddress}" autofocus></paper-input> 29 error-message="$i18n{notValidWebAddress}" autofocus></paper-input>
26 <paper-checkbox id="incognito" hidden$="[[!showIncognitoSessionOnly_]]"> 30 <div id="checkboxContainer">
27 $i18n{incognitoSiteOnly} 31 <paper-checkbox id="incognito"
28 </paper-checkbox> 32 hidden$="[[!showIncognitoSessionOnly_]]">
Dan Beam 2017/04/19 01:20:08 can you just change hidden$= to using visibility:
dschuyler 2017/04/19 19:20:40 Done.
33 $i18n{incognitoSiteOnly}
34 </paper-checkbox>
35 </div>
29 </div> 36 </div>
30 <div class="button-container"> 37 <div class="button-container">
31 <paper-button class="cancel-button" on-tap="onCancelTap_"> 38 <paper-button class="cancel-button" on-tap="onCancelTap_">
32 $i18n{cancel} 39 $i18n{cancel}
33 </paper-button> 40 </paper-button>
34 <paper-button class="action-button" id="add" 41 <paper-button class="action-button" id="add" on-tap="onSubmit_"
35 on-tap="onSubmit_" disabled> 42 disabled>
36 $i18n{add} 43 $i18n{add}
37 </paper-button> 44 </paper-button>
38 </div> 45 </div>
39 </dialog> 46 </dialog>
40 </template> 47 </template>
41 <script src="add_site_dialog.js"></script> 48 <script src="add_site_dialog.js"></script>
42 </dom-module> 49 </dom-module>
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698