Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(512)

Unified Diff: components/network_session_configurator/network_session_configurator.cc

Issue 2821053004: Revert of Remove the code to store and load QUIC server configs in the disk cache. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/network_session_configurator/network_session_configurator_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/network_session_configurator/network_session_configurator.cc
diff --git a/components/network_session_configurator/network_session_configurator.cc b/components/network_session_configurator/network_session_configurator.cc
index a0432839a1aea6fdffeeaf39fb2d2fd6d107a21c..4bb6f7758405e4cdc701432788a56139a48f8a06 100644
--- a/components/network_session_configurator/network_session_configurator.cc
+++ b/components/network_session_configurator/network_session_configurator.cc
@@ -134,10 +134,32 @@
return net::ParseQuicConnectionOptions(it->second);
}
+float GetQuicLoadServerInfoTimeoutSrttMultiplier(
+ const VariationParameters& quic_trial_params) {
+ double value;
+ if (base::StringToDouble(
+ GetVariationParam(quic_trial_params, "load_server_info_time_to_srtt"),
+ &value)) {
+ return static_cast<float>(value);
+ }
+ return 0.0f;
+}
+
+bool ShouldQuicEnableConnectionRacing(
+ const VariationParameters& quic_trial_params) {
+ return base::LowerCaseEqualsASCII(
+ GetVariationParam(quic_trial_params, "enable_connection_racing"), "true");
+}
+
bool ShouldQuicEnableNonBlockingIO(
const VariationParameters& quic_trial_params) {
return base::LowerCaseEqualsASCII(
GetVariationParam(quic_trial_params, "enable_non_blocking_io"), "true");
+}
+
+bool ShouldQuicDisableDiskCache(const VariationParameters& quic_trial_params) {
+ return base::LowerCaseEqualsASCII(
+ GetVariationParam(quic_trial_params, "disable_disk_cache"), "true");
}
bool ShouldForceHolBlocking(const VariationParameters& quic_trial_params) {
@@ -273,8 +295,18 @@
ShouldRetryWithoutAltSvcOnQuicErrors(quic_trial_params);
if (params->enable_quic) {
+ float load_server_info_timeout_srtt_multiplier =
+ GetQuicLoadServerInfoTimeoutSrttMultiplier(quic_trial_params);
+ if (load_server_info_timeout_srtt_multiplier != 0) {
+ params->quic_load_server_info_timeout_srtt_multiplier =
+ load_server_info_timeout_srtt_multiplier;
+ }
+ params->quic_enable_connection_racing =
+ ShouldQuicEnableConnectionRacing(quic_trial_params);
params->quic_enable_non_blocking_io =
ShouldQuicEnableNonBlockingIO(quic_trial_params);
+ params->quic_disable_disk_cache =
+ ShouldQuicDisableDiskCache(quic_trial_params);
params->quic_force_hol_blocking = ShouldForceHolBlocking(quic_trial_params);
params->quic_connection_options =
GetQuicConnectionOptions(quic_trial_params);
« no previous file with comments | « no previous file | components/network_session_configurator/network_session_configurator_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698