Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(389)

Issue 2820983002: [DMC #1.2] Add DocumentMarkerListEditor::MoveMarkers() (Closed)

Created:
3 years, 8 months ago by rlanday
Modified:
3 years, 8 months ago
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add DocumentMarkerListEditor::MoveMarkers() Follow-up to https://codereview.chromium.org/2812423002/ (add DocumentMarkerListEditor class) and https://codereview.chromium.org/2819173002 (refactor DocumentMarkerController::MoveMarkers()): this CL moves some of the DocumentMarkerController::MoveMarkers() code into a new DocumentMarkerListEditor::MoveMarkers() method BUG=707867 Review-Url: https://codereview.chromium.org/2820983002 Cr-Commit-Position: refs/heads/master@{#465894} Committed: https://chromium.googlesource.com/chromium/src/+/954977d31f907b814ca4aef51bbd76fb9a55f1f5

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Fix header #

Patch Set 4 : Rebase #

Patch Set 5 : Rebase #

Total comments: 1

Patch Set 6 : Fix nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -18 lines) Patch
M third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.h View 1 2 3 4 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp View 1 2 3 4 5 2 chunks +30 lines, -18 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 27 (22 generated)
rlanday
3 years, 8 months ago (2017-04-17 06:47:20 UTC) #2
Xiaocheng
lgtm
3 years, 8 months ago (2017-04-18 03:45:53 UTC) #16
yosin_UTC9
lgtm w/ small nit https://codereview.chromium.org/2820983002/diff/80001/third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp File third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp (right): https://codereview.chromium.org/2820983002/diff/80001/third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp#newcode342 third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp:342: unsigned end_offset = length - ...
3 years, 8 months ago (2017-04-20 01:26:56 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2820983002/100001
3 years, 8 months ago (2017-04-20 02:16:00 UTC) #24
commit-bot: I haz the power
3 years, 8 months ago (2017-04-20 03:56:28 UTC) #27
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/954977d31f907b814ca4aef51bbd...

Powered by Google App Engine
This is Rietveld 408576698