Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 2820943002: Add detailed tracking for causes of invalid PageLoadTimings. (Closed)

Created:
3 years, 8 months ago by Bryan McQuade
Modified:
3 years, 8 months ago
CC:
asvitkine+watch_chromium.org, chromium-reviews, csharrison+watch_chromium.org, loading-reviews+metrics_chromium.org, speed-metrics-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add detailed tracking for causes of invalid PageLoadTimings. In https://codereview.chromium.org/2804093002 we added additional error codes to understand the root cause of ERR_BAD_TIMING_IPC. New data shows that ERR_BAD_TIMING_IPC_INVALID_TIMING is the primary cause. We know we are receiving invalid PageLoadTiming structs, but we don't yet know the specific cause. This change adds more detailed error codes to get insight here. BUG=712033 Review-Url: https://codereview.chromium.org/2820943002 Cr-Commit-Position: refs/heads/master@{#465108} Committed: https://chromium.googlesource.com/chromium/src/+/0c3532027893052475cd87ac0f6c758046f34415

Patch Set 1 #

Patch Set 2 : test fix #

Patch Set 3 : add tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+221 lines, -51 lines) Patch
M chrome/browser/page_load_metrics/metrics_web_contents_observer_unittest.cc View 1 2 3 chunks +81 lines, -0 lines 0 comments Download
M chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc View 1 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/browser/page_load_metrics/page_load_tracker.h View 1 chunk +43 lines, -0 lines 0 comments Download
M chrome/browser/page_load_metrics/page_load_tracker.cc View 1 2 6 chunks +56 lines, -51 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 2 chunks +33 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (14 generated)
Bryan McQuade
PTAL
3 years, 8 months ago (2017-04-17 13:00:10 UTC) #11
Charlie Harrison
LGTM
3 years, 8 months ago (2017-04-17 13:10:23 UTC) #12
Bryan McQuade
isherman, PTAL for histograms.xml, thanks!
3 years, 8 months ago (2017-04-17 13:23:00 UTC) #14
Ilya Sherman
metrics lgtm, thanks
3 years, 8 months ago (2017-04-18 00:11:03 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2820943002/40001
3 years, 8 months ago (2017-04-18 00:11:44 UTC) #17
commit-bot: I haz the power
3 years, 8 months ago (2017-04-18 02:35:15 UTC) #20
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/0c3532027893052475cd87ac0f6c...

Powered by Google App Engine
This is Rietveld 408576698