Various page_load_metrics cleanups and improvements

Various page_load_metrics cleanups and improvements

* break dependency on RenderViewHost where possible
* log more detailed error codes when an invalid timing IPC is received
* log whether each page load started in the foreground
* count the number of prerenders

The latter three are important in improving our understanding of metrics
differences we are seeing with browser side navigation enabled.

BUG=709140
Review-Url: https://codereview.chromium.org/2804093002
Cr-Commit-Position: refs/heads/master@{#463263}
Committed: https://chromium.googlesource.com/chromium/src/+/06c594634073ae8cc37099fadd15cd02ae035398

[Bryan McQuade, 2017-04-06 19:11:32]

The CQ bit was checked by bmcquade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-06 19:12:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Bryan McQuade, 2017-04-06 19:13:12]

Description was changed from

==========
Various page_load_metrics cleanups and improvements

* break dependency on RenderViewHost where possible
* log more detailed error codes when an invalid timing IPC is received
* log whether each page load started in the foreground

BUG=709140
==========

to

==========
Various page_load_metrics cleanups and improvements

* break dependency on RenderViewHost where possible
* log more detailed error codes when an invalid timing IPC is received
* log whether each page load started in the foreground

The latter two are important in improving our understanding of metrics
differences we are seeing with browser side navigation enabled.

BUG=709140
==========

[Bryan McQuade, 2017-04-06 19:34:51]

Description was changed from

==========
Various page_load_metrics cleanups and improvements

* break dependency on RenderViewHost where possible
* log more detailed error codes when an invalid timing IPC is received
* log whether each page load started in the foreground

The latter two are important in improving our understanding of metrics
differences we are seeing with browser side navigation enabled.

BUG=709140
==========

to

==========
Various page_load_metrics cleanups and improvements

* break dependency on RenderViewHost where possible
* log more detailed error codes when an invalid timing IPC is received
* log whether each page load started in the foreground
* count the number of prerenders

The latter three are important in improving our understanding of metrics
differences we are seeing with browser side navigation enabled.

BUG=709140
==========

[Bryan McQuade, 2017-04-06 19:35:57]

The CQ bit was checked by bmcquade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-06 19:36:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Bryan McQuade, 2017-04-06 19:39:05]

The CQ bit was checked by bmcquade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-06 19:39:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Bryan McQuade, 2017-04-06 20:01:56]

bmcquade@chromium.org changed reviewers:
+ csharrison@chromium.org

[Bryan McQuade, 2017-04-06 20:02:03]

PTAL, thanks!

[commit-bot: I haz the power, 2017-04-06 20:35:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-06 20:35:03]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Charlie Harrison, 2017-04-07 13:57:54]

It looks good but I think some tests need to be updated

[Bryan McQuade, 2017-04-07 14:24:51]

The CQ bit was checked by bmcquade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-07 14:24:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Bryan McQuade, 2017-04-07 15:06:56]

On 2017/04/07 at 13:57:54, csharrison wrote:
> It looks good but I think some tests need to be updated

Thanks! I had to update a test helper method to address this. PTAL, thanks!

[commit-bot: I haz the power, 2017-04-07 15:23:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-07 15:23:00]

Dry run: This issue passed the CQ dry run.

[Bryan McQuade, 2017-04-07 20:59:35]

bmcquade@chromium.org changed reviewers:
+ isherman@chromium.org

[Bryan McQuade, 2017-04-07 20:59:47]

isherman, PTAL for histograms.xml, thanks!

[Ilya Sherman, 2017-04-08 01:14:59]

Metrics LGTM % nits:

https://codereview.chromium.org/2804093002/diff/60001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2804093002/diff/60001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:46480: +    enum="Boolean">
nit: Could this be BooleanForeground with custom labels?

https://codereview.chromium.org/2804093002/diff/60001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:46501: +<histogram
name="PageLoad.Internal.Prerender" enum="Boolean">
nit: Please use BooleanHit here.

[Charlie Harrison, 2017-04-10 12:21:28]

lgtm

[Bryan McQuade, 2017-04-10 13:26:32]

The CQ bit was checked by bmcquade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-10 13:26:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Bryan McQuade, 2017-04-10 13:27:37]

addressed comments, thanks!

https://codereview.chromium.org/2804093002/diff/60001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2804093002/diff/60001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:46480: +    enum="Boolean">
On 2017/04/08 at 01:14:59, Ilya Sherman wrote:
> nit: Could this be BooleanForeground with custom labels?

Done

https://codereview.chromium.org/2804093002/diff/60001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:46501: +<histogram
name="PageLoad.Internal.Prerender" enum="Boolean">
On 2017/04/08 at 01:14:59, Ilya Sherman wrote:
> nit: Please use BooleanHit here.

Done

[commit-bot: I haz the power, 2017-04-10 14:39:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-10 14:39:36]

Dry run: This issue passed the CQ dry run.

[Bryan McQuade, 2017-04-10 14:40:54]

The CQ bit was checked by bmcquade@chromium.org

[Bryan McQuade, 2017-04-10 14:40:55]

The patchset sent to the CQ was uploaded after l-g-t-m from
isherman@chromium.org, csharrison@chromium.org
Link to the patchset: https://codereview.chromium.org/2804093002/#ps80001
(title: "address comments")

[commit-bot: I haz the power, 2017-04-10 14:41:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-10 14:46:26]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1491835254455340,
"parent_rev": "68d5bbddd28fd443982073c645aee01ed3f972de", "commit_rev":
"06c594634073ae8cc37099fadd15cd02ae035398"}

[commit-bot: I haz the power, 2017-04-10 14:47:20]

Description was changed from

==========
Various page_load_metrics cleanups and improvements

* break dependency on RenderViewHost where possible
* log more detailed error codes when an invalid timing IPC is received
* log whether each page load started in the foreground
* count the number of prerenders

The latter three are important in improving our understanding of metrics
differences we are seeing with browser side navigation enabled.

BUG=709140
==========

to

==========
Various page_load_metrics cleanups and improvements

* break dependency on RenderViewHost where possible
* log more detailed error codes when an invalid timing IPC is received
* log whether each page load started in the foreground
* count the number of prerenders

The latter three are important in improving our understanding of metrics
differences we are seeing with browser side navigation enabled.

BUG=709140

Review-Url: https://codereview.chromium.org/2804093002
Cr-Commit-Position: refs/heads/master@{#463263}
Committed:
https://chromium.googlesource.com/chromium/src/+/06c594634073ae8cc37099fadd15...
==========

[commit-bot: I haz the power, 2017-04-10 14:47:22]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/06c594634073ae8cc37099fadd15...