Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 2820913002: Add another FlashDownloadInterceptionTest test case. (Closed)

Created:
3 years, 8 months ago by Lei Zhang
Modified:
3 years, 8 months ago
Reviewers:
tommycli
CC:
chromium-reviews, jam
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add another FlashDownloadInterceptionTest test case. BUG=711966 Review-Url: https://codereview.chromium.org/2820913002 Cr-Commit-Position: refs/heads/master@{#465330} Committed: https://chromium.googlesource.com/chromium/src/+/7275eb16ae8249a51f924ffbd110dcff82c3651b

Patch Set 1 #

Patch Set 2 : fix #

Patch Set 3 : check query #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -5 lines) Patch
M chrome/browser/plugins/flash_download_interception.cc View 1 2 2 chunks +8 lines, -2 lines 0 comments Download
M chrome/browser/plugins/flash_download_interception_unittest.cc View 1 2 4 chunks +8 lines, -3 lines 0 comments Download

Messages

Total messages: 21 (16 generated)
Lei Zhang
3 years, 8 months ago (2017-04-16 04:29:27 UTC) #14
tommycli
lgtm thanks! Nice tests!
3 years, 8 months ago (2017-04-18 15:35:26 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2820913002/40001
3 years, 8 months ago (2017-04-18 18:53:51 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/7275eb16ae8249a51f924ffbd110dcff82c3651b
3 years, 8 months ago (2017-04-18 19:39:36 UTC) #20
Lei Zhang
3 years, 8 months ago (2017-04-18 21:13:43 UTC) #21
Message was sent while issue was closed.
Whoops, forgot to change the CL description to mention this does more than just
add the test case. Oh well.

Powered by Google App Engine
This is Rietveld 408576698