Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4788)

Unified Diff: chrome/browser/plugins/flash_download_interception_unittest.cc

Issue 2820913002: Add another FlashDownloadInterceptionTest test case. (Closed)
Patch Set: check query Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/plugins/flash_download_interception.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/plugins/flash_download_interception_unittest.cc
diff --git a/chrome/browser/plugins/flash_download_interception_unittest.cc b/chrome/browser/plugins/flash_download_interception_unittest.cc
index bd12b0b11ef2d3bf1746aa543a181e1d7a324496..2855e7fb03b71b750983d9f5dc5f46232de71bbc 100644
--- a/chrome/browser/plugins/flash_download_interception_unittest.cc
+++ b/chrome/browser/plugins/flash_download_interception_unittest.cc
@@ -42,7 +42,7 @@ TEST_F(FlashDownloadInterceptionTest, DownloadUrlVariations) {
base::test::ScopedFeatureList feature_list;
feature_list.InitAndEnableFeature(features::kPreferHtmlOverPlugins);
- const char* flash_intercept_urls[] = {
+ const char* const flash_intercept_urls[] = {
"https://get.adobe.com/flashplayer/",
"http://get.adobe.com/flash",
"http://get.adobe.com/fr/flashplayer/",
@@ -52,6 +52,8 @@ TEST_F(FlashDownloadInterceptionTest, DownloadUrlVariations) {
"http://adobe.com/go/CA-H-GET-FLASH",
"http://adobe.com/go/DE_CH-H-M-A2",
"http://adobe.com/go/gntray_dl_getflashplayer_jp",
+ "http://www.adobe.com/shockwave/download/download.cgi?"
+ "P1_Prod_Version=ShockwaveFlash",
};
for (auto* url : flash_intercept_urls) {
@@ -59,8 +61,9 @@ TEST_F(FlashDownloadInterceptionTest, DownloadUrlVariations) {
<< "Should have intercepted: " << url;
}
- const char* flash_no_intercept_urls[] = {
- "https://www.example.com", "http://example.com/get.adobe.com/flashplayer",
+ const char* const flash_no_intercept_urls[] = {
+ "https://www.examplefoo.com",
+ "http://examplefoo.com/get.adobe.com/flashplayer",
"http://ww.macromedia.com/go/getflashplayer",
"http://wwwxmacromedia.com/go/getflashplayer",
"http://www.adobe.com/software/flash/about/",
@@ -72,6 +75,8 @@ TEST_F(FlashDownloadInterceptionTest, DownloadUrlVariations) {
// Don't match text within the query or fragment.
"http://www.adobe.com/go/non-matching?foo=flashplayer",
"http://www.adobe.com/go/non-matching#!foo=flashplayer",
+ "http://www.adobe.com/shockwave/download/download.cgi?"
+ "P1_Prod_Version=SomethingElse",
};
for (auto* url : flash_no_intercept_urls) {
« no previous file with comments | « chrome/browser/plugins/flash_download_interception.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698