Make the analysis server integration tests driver only.

Make the analysis server integration tests driver only.

BUG=
R=brianwilkerson@google.com, scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/d02519aec45f917634fdbc89c03ab45f8b75258c

[devoncarew, 2017-04-15 03:53:25]

devoncarew@google.com changed reviewers:
+ brianwilkerson@google.com, scheglov@google.com

[devoncarew, 2017-04-15 03:53:26]

A redux of https://codereview.chromium.org/2710193002/ - this CL makes the
analysis server integration tests new-analysis-driver only. For analysis server
I believe this is safe now; the work to remove non-driver code will likely be
spread out over several CLs.

From a few different discussions in the office, there are several non-driver
clients of the analyzer, so the work to make that driver only will need a bit
more coordination.

[scheglov, 2017-04-17 15:23:13]

lgtm

[Brian Wilkerson, 2017-04-17 16:53:52]

lgtm, thanks!

https://codereview.chromium.org/2820893002/diff/1/pkg/analysis_server/test/in...
File pkg/analysis_server/test/integration/analysis/analysis_options_test.dart
(right):

https://codereview.chromium.org/2820893002/diff/1/pkg/analysis_server/test/in...
pkg/analysis_server/test/integration/analysis/analysis_options_test.dart:25: // 
  String options = sourcePath(AnalysisEngine.ANALYSIS_OPTIONS_YAML_FILE);
Given that 'fail' will throw an exception and none of the following code will be
executed anyway, leaving the following code uncommented will mean that it can be
updated if we refactor any of the code it references. That will make it easier
to maintain these tests until we can resolve the timeout issue(s).

[devoncarew, 2017-04-17 18:21:59]

https://codereview.chromium.org/2820893002/diff/1/pkg/analysis_server/test/in...
File pkg/analysis_server/test/integration/analysis/analysis_options_test.dart
(right):

https://codereview.chromium.org/2820893002/diff/1/pkg/analysis_server/test/in...
pkg/analysis_server/test/integration/analysis/analysis_options_test.dart:25: // 
  String options = sourcePath(AnalysisEngine.ANALYSIS_OPTIONS_YAML_FILE);
On 2017/04/17 16:53:52, Brian Wilkerson wrote:
> Given that 'fail' will throw an exception and none of the following code will
be
> executed anyway, leaving the following code uncommented will mean that it can
be
> updated if we refactor any of the code it references. That will make it easier
> to maintain these tests until we can resolve the timeout issue(s).

Ah, great point. Will update to uncomment.

[devoncarew, 2017-04-17 18:23:43]

Description was changed from

==========
Make the analysis server integration tests driver only.

BUG=
==========

to

==========
Make the analysis server integration tests driver only.

BUG=
R=brianwilkerson@google.com, scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/d02519aec45f917634fdbc89c03ab45f8b75258c
==========

[devoncarew, 2017-04-17 18:23:44]

Committed patchset #2 (id:20001) manually as
d02519aec45f917634fdbc89c03ab45f8b75258c (presubmit successful).