Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(522)

Unified Diff: pkg/analysis_server/test/integration/server/set_subscriptions_test.dart

Issue 2820893002: Make the analysis server integration tests driver only. (Closed)
Patch Set: uncomment test code Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/test/integration/server/set_subscriptions_test.dart
diff --git a/pkg/analysis_server/test/integration/server/set_subscriptions_test.dart b/pkg/analysis_server/test/integration/server/set_subscriptions_test.dart
index 9ec4f3fcf4911f5cea549e0095a27c7b085f2784..b89f14ef5dce3bcd877bc4f6e2ec2b1422d46aaf 100644
--- a/pkg/analysis_server/test/integration/server/set_subscriptions_test.dart
+++ b/pkg/analysis_server/test/integration/server/set_subscriptions_test.dart
@@ -13,13 +13,20 @@ import '../integration_tests.dart';
main() {
defineReflectiveSuite(() {
defineReflectiveTests(SetSubscriptionsTest);
- defineReflectiveTests(SetSubscriptionsTest_Driver);
});
}
-class AbstractSetSubscriptionsTest
- extends AbstractAnalysisServerIntegrationTest {
+@reflectiveTest
+class SetSubscriptionsTest extends AbstractAnalysisServerIntegrationTest {
+ @failingTest
test_setSubscriptions() {
+ // This test times out on the bots and has been disabled to keep them green.
+ // We need to discover the cause and re-enable it.
+
+ fail(
+ 'This test times out on the bots and has been disabled to keep them green.'
+ 'We need to discover the cause and re-enable it.');
+
bool statusReceived = false;
Completer analysisBegun = new Completer();
onServerStatus.listen((_) {
@@ -59,20 +66,3 @@ main() {
});
}
}
-
-@reflectiveTest
-class SetSubscriptionsTest extends AbstractSetSubscriptionsTest {}
-
-@reflectiveTest
-class SetSubscriptionsTest_Driver extends AbstractSetSubscriptionsTest {
- @override
- bool get enableNewAnalysisDriver => true;
-
- @failingTest
- @override
- test_setSubscriptions() {
- // This test times out on the bots and has been disabled to keep them green.
- // We need to discover the cause and re-enable it.
- fail('Timed out');
- }
-}

Powered by Google App Engine
This is Rietveld 408576698