Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(834)

Unified Diff: pkg/analysis_server/test/integration/integration_tests.dart

Issue 2820893002: Make the analysis server integration tests driver only. (Closed)
Patch Set: uncomment test code Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/test/integration/integration_tests.dart
diff --git a/pkg/analysis_server/test/integration/integration_tests.dart b/pkg/analysis_server/test/integration/integration_tests.dart
index b2ad8278752cf2285b037aac20d9df0a04f27687..2417cb12ae49017468c11cdd91b3b5b70f159938 100644
--- a/pkg/analysis_server/test/integration/integration_tests.dart
+++ b/pkg/analysis_server/test/integration/integration_tests.dart
@@ -159,11 +159,6 @@ abstract class AbstractAnalysisServerIntegrationTest
}
/**
- * Return `true` if the new analysis driver should be used by these tests.
- */
- bool get enableNewAnalysisDriver => false;
-
- /**
* Print out any messages exchanged with the server. If some messages have
* already been exchanged with the server, they are printed out immediately.
*/
@@ -266,7 +261,6 @@ abstract class AbstractAnalysisServerIntegrationTest
server.start(
checked: checked,
diagnosticPort: diagnosticPort,
- enableNewAnalysisDriver: enableNewAnalysisDriver,
servicesPort: servicesPort);
/**
@@ -657,7 +651,6 @@ class Server {
Future start({
bool checked: true,
int diagnosticPort,
- bool enableNewAnalysisDriver: false,
bool profileServer: false,
String sdkPath,
int servicesPort,
@@ -711,9 +704,6 @@ class Server {
if (useAnalysisHighlight2) {
arguments.add('--useAnalysisHighlight2');
}
- if (!enableNewAnalysisDriver) {
- arguments.add('--disable-new-analysis-driver');
- }
// print('Launching $serverPath');
// print('$dartBinary ${arguments.join(' ')}');
// TODO(devoncarew): We could experiment with instead launching the analysis

Powered by Google App Engine
This is Rietveld 408576698