Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Issue 2820823003: Revert "Fix the size of video textures uploaded to WebGL." (Closed)

Created:
3 years, 8 months ago by Ken Russell (switch to Gerrit)
Modified:
3 years, 8 months ago
CC:
apacible+watch_chromium.org, blink-reviews, blink-reviews-api_chromium.org, blink-reviews-html_chromium.org, chfremer+watch_chromium.org, chromium-reviews, darin-cc_chromium.org, dglazkov+blink, eric.carlson_apple.com, erickung+watch_chromium.org, feature-media-reviews_chromium.org, haraken, jam, mcasas+watch+vc_chromium.org, miu+watch_chromium.org, mlamouri+watch-content_chromium.org, mlamouri+watch-blink_chromium.org, posciak+watch_chromium.org, Srirama, xjz+watch_chromium.org
Target Ref:
refs/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

Revert "Fix the size of video textures uploaded to WebGL." This reverts commit 4910ae5b242c441bd047b78bb5cb46ad954920fa. This revert is being done only on the M58 branch, as the lower-risk option of fixing the draw/upload paths from video to both 2D canvas and WebGL. Tested locally. Verified that new WebGL conformance test texture-corner-case-videos.html passes with this revert applied. BUG=672895, 701060 TBR=chrishtr@chromium.org,esprehn@chromium.org,dalecurtis@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2820823003 . Cr-Commit-Position: refs/branch-heads/3029@{#723} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/df726b319141fe6869bdae70100bf24daa460d2f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -53 lines) Patch
M content/renderer/media/webmediaplayer_ms.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/renderer/media/webmediaplayer_ms.cc View 2 chunks +4 lines, -1 line 0 comments Download
M media/blink/webmediaplayer_impl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M media/blink/webmediaplayer_impl.cc View 2 chunks +4 lines, -1 line 0 comments Download
M media/renderers/skcanvas_video_renderer.h View 2 chunks +4 lines, -6 lines 0 comments Download
M media/renderers/skcanvas_video_renderer.cc View 6 chunks +14 lines, -24 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLVideoElement.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLVideoElement.cpp View 1 chunk +5 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp View 2 chunks +8 lines, -11 lines 0 comments Download
M third_party/WebKit/public/platform/WebMediaPlayer.h View 1 chunk +3 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
Ken Russell (switch to Gerrit)
FYI. This is a manual revert on the M58 branch of a CL which went ...
3 years, 8 months ago (2017-04-14 22:56:13 UTC) #4
DaleCurtis
media/ lgtm
3 years, 8 months ago (2017-04-14 22:57:32 UTC) #5
Ken Russell (switch to Gerrit)
3 years, 8 months ago (2017-04-14 22:58:23 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
df726b319141fe6869bdae70100bf24daa460d2f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698