Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1518)

Unified Diff: third_party/WebKit/public/platform/WebMediaPlayer.h

Issue 2820823003: Revert "Fix the size of video textures uploaded to WebGL." (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/public/platform/WebMediaPlayer.h
diff --git a/third_party/WebKit/public/platform/WebMediaPlayer.h b/third_party/WebKit/public/platform/WebMediaPlayer.h
index 85a95762e065fcfe7aef3f770e9f3ecac0f99d5b..745a53888a250475c9c9b4cdd77c4f526735022a 100644
--- a/third_party/WebKit/public/platform/WebMediaPlayer.h
+++ b/third_party/WebKit/public/platform/WebMediaPlayer.h
@@ -181,21 +181,16 @@ class WebMediaPlayer {
virtual void paint(WebCanvas*, const WebRect&, cc::PaintFlags&) = 0;
- // TODO(kbr): remove non-|target| version. crbug.com/349871
- //
- // Do a GPU-GPU texture copy of the natural size of the current
- // video frame to |texture|. Caller is responsible for allocating
- // |texture| with the appropriate size. If the copy is impossible or
- // fails, it returns false.
+ // TODO(dshwang): remove non-|target| version. crbug.com/349871
virtual bool copyVideoTextureToPlatformTexture(gpu::gles2::GLES2Interface*,
unsigned texture,
+ unsigned internalFormat,
+ unsigned type,
bool premultiplyAlpha,
bool flipY) {
return false;
}
- // TODO(kbr): when updating calling code to use this, remove the
- // |internalFormat| and |type| parameters. crbug.com/349871
// Do a GPU-GPU textures copy. If the copy is impossible or fails, it returns
// false.
virtual bool copyVideoTextureToPlatformTexture(gpu::gles2::GLES2Interface*,
« no previous file with comments | « third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698