Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 2820793003: Track Previews infobar dismissals due to tab closure (Closed)

Created:
3 years, 8 months ago by megjablon
Modified:
3 years, 8 months ago
Reviewers:
RyanSturm, Ilya Sherman
CC:
chromium-reviews, asvitkine+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Track Previews infobar dismissals due to tab closure BUG=706528 Review-Url: https://codereview.chromium.org/2820793003 Cr-Commit-Position: refs/heads/master@{#465032} Committed: https://chromium.googlesource.com/chromium/src/+/e111e380e8f4178c4a1907c4fa6b4408a22800bc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -5 lines) Patch
M chrome/browser/previews/previews_infobar_delegate.h View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/previews/previews_infobar_delegate.cc View 4 chunks +8 lines, -5 lines 0 comments Download
M chrome/browser/previews/previews_infobar_delegate_unittest.cc View 1 chunk +17 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
megjablon
3 years, 8 months ago (2017-04-14 23:50:30 UTC) #4
RyanSturm
lgtm
3 years, 8 months ago (2017-04-14 23:53:25 UTC) #5
megjablon
isherman: histograms.xml
3 years, 8 months ago (2017-04-15 00:04:06 UTC) #7
Ilya Sherman
histograms.xml lgtm
3 years, 8 months ago (2017-04-17 19:57:57 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2820793003/1
3 years, 8 months ago (2017-04-17 19:58:38 UTC) #12
commit-bot: I haz the power
3 years, 8 months ago (2017-04-17 21:54:07 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e111e380e8f4178c4a1907c4fa6b...

Powered by Google App Engine
This is Rietveld 408576698