Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Unified Diff: chrome/browser/previews/previews_infobar_delegate.cc

Issue 2820793003: Track Previews infobar dismissals due to tab closure (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/previews/previews_infobar_delegate.cc
diff --git a/chrome/browser/previews/previews_infobar_delegate.cc b/chrome/browser/previews/previews_infobar_delegate.cc
index 1a1a9e1e081b5b5ec27f86b417a068a6da5f699a..2444cde5f1f754ff06d318667066884845801f65 100644
--- a/chrome/browser/previews/previews_infobar_delegate.cc
+++ b/chrome/browser/previews/previews_infobar_delegate.cc
@@ -49,6 +49,8 @@ void RecordPreviewsInfoBarAction(
PreviewsInfoBarDelegate::~PreviewsInfoBarDelegate() {
if (!on_dismiss_callback_.is_null())
on_dismiss_callback_.Run(false);
+
+ RecordPreviewsInfoBarAction(infobar_type_, infobar_dismissed_action_);
}
// static
@@ -93,6 +95,7 @@ PreviewsInfoBarDelegate::PreviewsInfoBarDelegate(
const OnDismissPreviewsInfobarCallback& on_dismiss_callback)
: ConfirmInfoBarDelegate(),
infobar_type_(infobar_type),
+ infobar_dismissed_action_(INFOBAR_DISMISSED_BY_TAB_CLOSURE),
message_text_(l10n_util::GetStringUTF16(
is_data_saver_user ? IDS_PREVIEWS_INFOBAR_SAVED_DATA_TITLE
: IDS_PREVIEWS_INFOBAR_FASTER_PAGE_TITLE)),
@@ -113,14 +116,14 @@ int PreviewsInfoBarDelegate::GetIconId() const {
bool PreviewsInfoBarDelegate::ShouldExpire(
const NavigationDetails& details) const {
- RecordPreviewsInfoBarAction(
- infobar_type_, details.is_reload ? INFOBAR_DISMISSED_BY_RELOAD
- : INFOBAR_DISMISSED_BY_NAVIGATION);
+ infobar_dismissed_action_ = details.is_reload
+ ? INFOBAR_DISMISSED_BY_RELOAD
+ : INFOBAR_DISMISSED_BY_NAVIGATION;
return InfoBarDelegate::ShouldExpire(details);
}
void PreviewsInfoBarDelegate::InfoBarDismissed() {
- RecordPreviewsInfoBarAction(infobar_type_, INFOBAR_DISMISSED_BY_USER);
+ infobar_dismissed_action_ = INFOBAR_DISMISSED_BY_USER;
}
base::string16 PreviewsInfoBarDelegate::GetMessageText() const {
@@ -136,7 +139,7 @@ base::string16 PreviewsInfoBarDelegate::GetLinkText() const {
}
bool PreviewsInfoBarDelegate::LinkClicked(WindowOpenDisposition disposition) {
- RecordPreviewsInfoBarAction(infobar_type_, INFOBAR_LOAD_ORIGINAL_CLICKED);
+ infobar_dismissed_action_ = INFOBAR_LOAD_ORIGINAL_CLICKED;
if (!on_dismiss_callback_.is_null())
on_dismiss_callback_.Run(true);
on_dismiss_callback_.Reset();
« no previous file with comments | « chrome/browser/previews/previews_infobar_delegate.h ('k') | chrome/browser/previews/previews_infobar_delegate_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698