Remove usage of Tab's |url| property from TabUsageRecorder.

Remove usage of Tab's |url| property from TabUsageRecorder.

BUG=546208
Review-Url: https://codereview.chromium.org/2820763002
Cr-Commit-Position: refs/heads/master@{#476528}
Committed: https://chromium.googlesource.com/chromium/src/+/8dd141c8941e66957a4627ae51b3918c9f457b20

[kkhorimoto, 2017-04-14 20:40:13]

visible => lastCommitted

[kkhorimoto, 2017-04-14 20:40:46]

kkhorimoto@chromium.org changed reviewers:
+ eugenebut@chromium.org, rohitrao@chromium.org, sdefresne@chromium.org

[kkhorimoto, 2017-04-14 20:40:47]

https://codereview.chromium.org/2820763002/diff/20001/ios/chrome/browser/metr...
File ios/chrome/browser/metrics/tab_usage_recorder.mm (right):

https://codereview.chromium.org/2820763002/diff/20001/ios/chrome/browser/metr...
ios/chrome/browser/metrics/tab_usage_recorder.mm:297: return
tab.lastCommittedURL.SchemeIs(kChromeUIScheme);
chrome:// URLs are never pending, so lastCommitted should be sufficient.

[Eugene But (OOO till 7-30), 2017-04-14 21:48:09]

https://codereview.chromium.org/2820763002/diff/20001/ios/chrome/browser/metr...
File ios/chrome/browser/metrics/tab_usage_recorder.mm (right):

https://codereview.chromium.org/2820763002/diff/20001/ios/chrome/browser/metr...
ios/chrome/browser/metrics/tab_usage_recorder.mm:297: return
tab.lastCommittedURL.SchemeIs(kChromeUIScheme);
On 2017/04/14 20:40:47, kkhorimoto_ wrote:
> chrome:// URLs are never pending, so lastCommitted should be sufficient.
WebUI can be a pending URL, so maybe we should check both pending and last
committed?

[kkhorimoto, 2017-05-31 22:46:55]

The CQ bit was checked by kkhorimoto@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-31 22:47:26]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kkhorimoto, 2017-05-31 22:53:53]

The CQ bit was checked by kkhorimoto@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-31 22:54:24]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kkhorimoto, 2017-05-31 23:06:17]

https://codereview.chromium.org/2820763002/diff/20001/ios/chrome/browser/metr...
File ios/chrome/browser/metrics/tab_usage_recorder.mm (right):

https://codereview.chromium.org/2820763002/diff/20001/ios/chrome/browser/metr...
ios/chrome/browser/metrics/tab_usage_recorder.mm:297: return
tab.lastCommittedURL.SchemeIs(kChromeUIScheme);
On 2017/04/14 21:48:09, Eugene But wrote:
> On 2017/04/14 20:40:47, kkhorimoto_ wrote:
> > chrome:// URLs are never pending, so lastCommitted should be sufficient.
> WebUI can be a pending URL, so maybe we should check both pending and last
> committed?

Done.

[Eugene But (OOO till 7-30), 2017-05-31 23:45:32]

lgtm

[commit-bot: I haz the power, 2017-06-01 00:05:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-01 00:05:40]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[rohitrao (ping after 24h), 2017-06-01 11:00:37]

Looks like there are real crashes in TabUsageRecorderTest.

Otherwise testing pending_item first sgtm.

[kkhorimoto, 2017-06-01 18:49:26]

fixed tab mock

[kkhorimoto, 2017-06-01 18:49:27]

The CQ bit was checked by kkhorimoto@chromium.org

[kkhorimoto, 2017-06-01 18:49:29]

The patchset sent to the CQ was uploaded after l-g-t-m from
eugenebut@chromium.org
Link to the patchset: https://codereview.chromium.org/2820763002/#ps60001
(title: "fixed tab mock")

[commit-bot: I haz the power, 2017-06-01 18:50:20]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-01 19:05:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-01 19:05:21]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[kkhorimoto, 2017-06-01 19:45:40]

fix gn

[kkhorimoto, 2017-06-01 19:45:41]

The CQ bit was checked by kkhorimoto@chromium.org

[kkhorimoto, 2017-06-01 19:45:41]

The patchset sent to the CQ was uploaded after l-g-t-m from
eugenebut@chromium.org
Link to the patchset: https://codereview.chromium.org/2820763002/#ps80001
(title: "fix gn")

[commit-bot: I haz the power, 2017-06-01 19:46:29]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-01 19:50:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-01 19:50:36]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[kkhorimoto, 2017-06-01 20:15:57]

rebase

[kkhorimoto, 2017-06-01 20:15:58]

The CQ bit was checked by kkhorimoto@chromium.org

[kkhorimoto, 2017-06-01 20:15:58]

The patchset sent to the CQ was uploaded after l-g-t-m from
eugenebut@chromium.org
Link to the patchset: https://codereview.chromium.org/2820763002/#ps100001
(title: "rebase")

[commit-bot: I haz the power, 2017-06-01 20:16:49]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-01 21:22:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-01 21:22:27]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[kkhorimoto, 2017-06-01 22:40:06]

The CQ bit was checked by kkhorimoto@chromium.org

[commit-bot: I haz the power, 2017-06-01 22:41:13]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-02 02:36:39]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1496356806868570,
"parent_rev": "97474434c7f06805f9bdc97c2848ef25cf07f550", "commit_rev":
"8dd141c8941e66957a4627ae51b3918c9f457b20"}

[commit-bot: I haz the power, 2017-06-02 02:36:52]

Description was changed from

==========
Remove usage of Tab's |url| property from TabUsageRecorder.

BUG=546208
==========

to

==========
Remove usage of Tab's |url| property from TabUsageRecorder.

BUG=546208

Review-Url: https://codereview.chromium.org/2820763002
Cr-Commit-Position: refs/heads/master@{#476528}
Committed:
https://chromium.googlesource.com/chromium/src/+/8dd141c8941e66957a4627ae51b3...
==========

[commit-bot: I haz the power, 2017-06-02 02:36:54]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/8dd141c8941e66957a4627ae51b3...