Remove usage of Tab's |url| property from TabUsageRecorder.

ios/chrome/browser/metrics/tab_usage_recorder_unittest.mm

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <memory>
 
+#include "base/memory/ptr_util.h"
 #include "base/message_loop/message_loop.h"
 #include "base/metrics/histogram_samples.h"
 #include "base/stl_util.h"
 #include "base/test/histogram_tester.h"
 #import "ios/chrome/browser/metrics/previous_session_info.h"
 #include "ios/chrome/browser/metrics/tab_usage_recorder.h"
 #import "ios/chrome/browser/metrics/tab_usage_recorder_delegate.h"
 #import "ios/chrome/browser/tabs/tab.h"
 #include "ios/testing/ocmock_complex_type_helper.h"
+#import "ios/web/public/test/fakes/test_navigation_manager.h"
+#import "ios/web/public/test/fakes/test_web_state.h"
 #include "ios/web/public/test/test_web_thread.h"
 #import "ios/web/web_state/ui/crw_web_controller.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "testing/platform_test.h"
 #include "third_party/ocmock/ocmock_extensions.h"
 
 #if !defined(__has_feature) || !__has_feature(objc_arc)
 #error "This file requires ARC support."
 #endif
 
 @interface TURTestTabMock : OCMockComplexTypeHelper {
   GURL _url;
+  GURL _lastCommittedURL;
+  GURL _visibleURL;
+  web::TestWebState _webState;
 }
 
 @property(nonatomic, assign) const GURL& url;
+@property(nonatomic, assign) const GURL& lastCommittedURL;
+@property(nonatomic, assign) const GURL& visibleURL;
+@property(nonatomic, readonly) web::WebState* webState;
+
 @end
 
 @implementation TURTestTabMock
 - (const GURL&)url {
   return _url;
 }
 - (void)setUrl:(const GURL&)url {
   _url = url;
 }
+- (const GURL&)lastCommittedURL {
+  return _lastCommittedURL;
+}
+- (void)setLastCommittedURL:(const GURL&)lastCommittedURL {
+  _lastCommittedURL = lastCommittedURL;
+}
+- (const GURL&)visibleURL {
+  return _visibleURL;
+}
+- (void)setVisibleURL:(const GURL&)visibleURL {
+  _visibleURL = visibleURL;
+}
+- (web::WebState*)webState {
+  if (!_webState.GetNavigationManager()) {
+    _webState.SetNavigationManager(
+        base::MakeUnique<web::TestNavigationManager>());
+  }
+  return &_webState;
+}
 @end
 
 // A mock TabUsageRecorderDelegate which allows the unit tests to control
 // the count of live tabs returned from the |liveTabsCount| delegate method.
 @interface MockTabUsageRecorderDelegate : NSObject<TabUsageRecorderDelegate> {
   NSUInteger _tabCount;
 }
 
 // Sets the live tab count returned from the |liveTabsCount| delegate method.
 - (void)setLiveTabsCount:(NSUInteger)count;
@@ skipping 49 matching lines @@
   }
 
   id MockTab(bool inMemory) {
     id tab_mock = [[TURTestTabMock alloc]
         initWithRepresentedObject:[OCMockObject mockForClass:[Tab class]]];
     id web_controller_mock =
         [OCMockObject mockForClass:[CRWWebController class]];
     [[[tab_mock stub] andReturn:web_controller_mock] webController];
     [[[tab_mock stub] andReturnBool:false] isPrerenderTab];
     [tab_mock setUrl:webUrl_];
+    [tab_mock setLastCommittedURL:webUrl_];
+    [tab_mock setVisibleURL:webUrl_];
     [[[web_controller_mock stub] andReturnBool:inMemory] isViewAlive];
     [[web_controller_mock stub] removeObserver:OCMOCK_ANY];
     return tab_mock;
   }
 
   GURL webUrl_;
   GURL nativeUrl_;
   std::unique_ptr<base::MessageLoop> loop_;
   std::unique_ptr<web::TestWebThread> ui_thread_;
   std::unique_ptr<base::HistogramTester> histogram_tester_;
@@ skipping 47 matching lines @@
   }
   tab_usage_recorder_->RecordTabSwitched(tab_mock_a, tab_mock_b);
   histogram_tester_->ExpectUniqueSample(kPageLoadsBeforeEvictedTabSelected,
                                         kNumReloads, 1);
 }
 
 TEST_F(TabUsageRecorderTest, CountNativePageLoadsBeforeEvictedTab) {
   id tab_mock_a = MockTab(true);
   id tab_mock_b = MockTab(false);
   [tab_mock_a setUrl:nativeUrl_];
+  [tab_mock_a setLastCommittedURL:nativeUrl_];
+  [tab_mock_a setVisibleURL:nativeUrl_];
   [tab_mock_b setUrl:nativeUrl_];
+  [tab_mock_b setLastCommittedURL:nativeUrl_];
+  [tab_mock_b setVisibleURL:nativeUrl_];
 
   // Call reload an arbitrary number of times.
   const int kNumReloads = 4;
   for (int i = 0; i < kNumReloads; i++) {
     tab_usage_recorder_->RecordPageLoadStart(tab_mock_a);
   }
   tab_usage_recorder_->RecordTabSwitched(tab_mock_a, tab_mock_b);
   histogram_tester_->ExpectTotalCount(kPageLoadsBeforeEvictedTabSelected, 0);
 }
 
@@ skipping 173 matching lines @@
 
   tab_usage_recorder_->RendererTerminated(tab_mock_b, false);
   tab_usage_recorder_->RecordTabSwitched(tab_mock_a, tab_mock_b);
 
   histogram_tester_->ExpectUniqueSample(
       kSelectedTabHistogramName,
       TabUsageRecorder::EVICTED_DUE_TO_RENDERER_TERMINATION, 1);
 }
 
 }  // namespace