Reland "Update third_party/checkstyle to 7.6.1"

Reland "Update third_party/checkstyle to 7.6.1"

Reverted in:
https://codereview.chromium.org/2807753003/

Reason for reland:
1. No longer uses Android-related wrapper script for downloading
checkstyle binary file.
2. chromium_presubmit bot now supports Java 8.

TBR=klobag@chromium.org
BUG=703238
Review-Url: https://codereview.chromium.org/2820583002
Cr-Commit-Position: refs/heads/master@{#465999}
Committed: https://chromium.googlesource.com/chromium/src/+/ccf6d26c344204648d226c7b1903179f389230c2

[F, 2017-04-13 18:17:29]

Created Revert of Revert "Update third_party/checkstyle to 7.6.1"

[agrieve, 2017-04-13 19:21:30]

Description was changed from

==========
Revert of Revert "Update third_party/checkstyle to 7.6.1" (patchset #1 id:1 of
https://codereview.chromium.org/2807753003/ )

Reason for revert:
Will update when the missing file issue is fixed

Original issue's description:
> Revert "Update third_party/checkstyle to 7.6.1"
> 
> This reverts commit dbce02f63421f7d446d6ef317b456f6ae911f63b.
> 
> Reason for revert:
> Breaking cq presubmit step
> 
> Original issue's description:
> > Update third_party/checkstyle to 7.6.1
> >
> > This CL updates third_party/checkstyle to 7.6.1 so checkstyle would
> > work with Java 8 lambda features.
> >
> > BUG=703238
> >
> > Review-Url: https://codereview.chromium.org/2799303003
> > Cr-Commit-Position: refs/heads/master@{#462968}
> > Committed:
https://chromium.googlesource.com/chromium/src/+/dbce02f63421f7d446d6ef317b45...
> 
>
TBR=agrieve@chromium.org,nyquist@chromium.org,jbudorick@chromium.org,klobag@c...
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=703238
> 
> Review-Url: https://codereview.chromium.org/2807753003 .
> Cr-Commit-Position: refs/heads/master@{#463021}
> Committed:
https://chromium.googlesource.com/chromium/src/+/6fb89ced75c50e77bc5c6a29bb82...

TBR=agrieve@chromium.org,jbudorick@chromium.org,jbudorick@google.com,klobag@c...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=703238
==========

to

==========
Reland "Update third_party/checkstyle to 7.6.1"

Reverted in:
https://codereview.chromium.org/2807753003/

Reason for reland:
Will update when the missing file issue is fixed

BUG=703238
==========

[nyquist, 2017-04-18 18:31:28]

Is this CL ready for review?

[F, 2017-04-18 21:06:21]

On 2017/04/18 18:31:28, nyquist wrote:
> Is this CL ready for review?

Sorry, it is not ready yet. It's waiting on Java 8 update on the
chromium_presubmit bot. I'll update the CL when it's ready. Thanks!

[F, 2017-04-19 14:20:27]

The CQ bit was checked by zpeng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-19 14:20:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[F, 2017-04-19 14:58:05]

Description was changed from

==========
Reland "Update third_party/checkstyle to 7.6.1"

Reverted in:
https://codereview.chromium.org/2807753003/

Reason for reland:
Will update when the missing file issue is fixed

BUG=703238
==========

to

==========
Reland "Update third_party/checkstyle to 7.6.1"

Reverted in:
https://codereview.chromium.org/2807753003/

Reason for reland:
1. No longer uses Android-related wrapper script for downloading
checkstyle binary file.
2. chromium_presubmit bot now supports Java 8.

BUG=703238
==========

[F, 2017-04-19 14:58:05]

zpeng@chromium.org changed reviewers:
- asvitkine@chromium.org, jbudorick@google.com, klobag@chromium.org

[commit-bot: I haz the power, 2017-04-19 15:36:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-19 15:36:30]

Dry run: This issue passed the CQ dry run.

[F, 2017-04-19 17:15:56]

Hi Andrew, John, and Tommy, PTAL. Thanks!

I've changed how the binary is downloaded and tested it on CQ with changes in
Java code.

[agrieve, 2017-04-19 17:36:54]

lgtm /w nit. Good idea about updating the README for future updaters.

https://codereview.chromium.org/2820583002/diff/190001/DEPS
File DEPS (right):

https://codereview.chromium.org/2820583002/diff/190001/DEPS#newcode926
DEPS:926: # Pull checkstyle binaries using checked-in hashes.
nit: this comment isn't really useful. I'd remove it.

[jbudorick, 2017-04-19 18:32:33]

lgtm

[nyquist, 2017-04-19 20:57:56]

lgtm

[F, 2017-04-19 22:08:24]

The CQ bit was checked by zpeng@chromium.org

[F, 2017-04-19 22:08:24]

The patchset sent to the CQ was uploaded after l-g-t-m from agrieve@chromium.org
Link to the patchset: https://codereview.chromium.org/2820583002/#ps210001
(title: "nit")

[commit-bot: I haz the power, 2017-04-19 22:09:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-19 22:21:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-19 22:21:32]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[F, 2017-04-19 22:25:24]

zpeng@chromium.org changed reviewers:
+ klobag@chromium.org

[F, 2017-04-19 22:25:25]

Hi Grace, PTAL. Thanks!

[F, 2017-04-19 22:28:44]

The CQ bit was checked by zpeng@chromium.org

[commit-bot: I haz the power, 2017-04-19 22:29:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-19 22:39:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-19 22:39:19]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[F, 2017-04-20 14:11:58]

Description was changed from

==========
Reland "Update third_party/checkstyle to 7.6.1"

Reverted in:
https://codereview.chromium.org/2807753003/

Reason for reland:
1. No longer uses Android-related wrapper script for downloading
checkstyle binary file.
2. chromium_presubmit bot now supports Java 8.

BUG=703238
==========

to

==========
Reland "Update third_party/checkstyle to 7.6.1"

Reverted in:
https://codereview.chromium.org/2807753003/

Reason for reland:
1. No longer uses Android-related wrapper script for downloading
checkstyle binary file.
2. chromium_presubmit bot now supports Java 8.

TBR=klobag@chromium.org
BUG=703238
==========

[F, 2017-04-20 14:12:06]

The CQ bit was checked by zpeng@chromium.org

[commit-bot: I haz the power, 2017-04-20 14:12:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-20 14:17:26]

CQ is committing da patch.

Bot data: {"patchset_id": 210001, "attempt_start_ts": 1492697526736440,
"parent_rev": "4da3e35ba0d85a1130dac12acbb699ba0afb63e6", "commit_rev":
"ccf6d26c344204648d226c7b1903179f389230c2"}

[commit-bot: I haz the power, 2017-04-20 14:17:38]

Description was changed from

==========
Reland "Update third_party/checkstyle to 7.6.1"

Reverted in:
https://codereview.chromium.org/2807753003/

Reason for reland:
1. No longer uses Android-related wrapper script for downloading
checkstyle binary file.
2. chromium_presubmit bot now supports Java 8.

TBR=klobag@chromium.org
BUG=703238
==========

to

==========
Reland "Update third_party/checkstyle to 7.6.1"

Reverted in:
https://codereview.chromium.org/2807753003/

Reason for reland:
1. No longer uses Android-related wrapper script for downloading
checkstyle binary file.
2. chromium_presubmit bot now supports Java 8.

TBR=klobag@chromium.org
BUG=703238

Review-Url: https://codereview.chromium.org/2820583002
Cr-Commit-Position: refs/heads/master@{#465999}
Committed:
https://chromium.googlesource.com/chromium/src/+/ccf6d26c344204648d226c7b1903...
==========

[commit-bot: I haz the power, 2017-04-20 14:17:39]

Committed patchset #4 (id:210001) as
https://chromium.googlesource.com/chromium/src/+/ccf6d26c344204648d226c7b1903...