Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 2807753003: Revert "Update third_party/checkstyle to 7.6.1" (Closed)

Created:
3 years, 8 months ago by Alexei Svitkine (slow)
Modified:
3 years, 8 months ago
CC:
chromium-reviews, mikecase+watch_chromium.org, jbudorick+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Update third_party/checkstyle to 7.6.1" This reverts commit dbce02f63421f7d446d6ef317b456f6ae911f63b. Reason for revert: Breaking cq presubmit step Original issue's description: > Update third_party/checkstyle to 7.6.1 > > This CL updates third_party/checkstyle to 7.6.1 so checkstyle would > work with Java 8 lambda features. > > BUG=703238 > > Review-Url: https://codereview.chromium.org/2799303003 > Cr-Commit-Position: refs/heads/master@{#462968} > Committed: https://chromium.googlesource.com/chromium/src/+/dbce02f63421f7d446d6ef317b456f6ae911f63b TBR=agrieve@chromium.org,nyquist@chromium.org,jbudorick@chromium.org,klobag@chromium.org,jbudorick@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=703238 Review-Url: https://codereview.chromium.org/2807753003 . Cr-Commit-Position: refs/heads/master@{#463021} Committed: https://chromium.googlesource.com/chromium/src/+/6fb89ced75c50e77bc5c6a29bb820534d16d5279

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -43 lines) Patch
M DEPS View 1 chunk +0 lines, -10 lines 0 comments Download
M third_party/.gitignore View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/checkstyle/OWNERS View 1 chunk +1 line, -5 lines 0 comments Download
M third_party/checkstyle/README.chromium View 2 chunks +4 lines, -14 lines 0 comments Download
A third_party/checkstyle/checkstyle-6.5-all.jar View Binary file 0 comments Download
D third_party/checkstyle/checkstyle-7.6.1-all.jar.sha1 View 1 chunk +0 lines, -1 line 0 comments Download
M tools/android/checkstyle/checkstyle.py View 2 chunks +2 lines, -12 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
Alexei Svitkine (slow)
Committed patchset #1 (id:1) manually as 6fb89ced75c50e77bc5c6a29bb820534d16d5279 (presubmit successful).
3 years, 8 months ago (2017-04-07 22:26:36 UTC) #2
F
3 years, 8 months ago (2017-04-13 18:17:28 UTC) #3
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2820583002/ by zpeng@chromium.org.

The reason for reverting is: Will update when the missing file issue is fixed.

Powered by Google App Engine
This is Rietveld 408576698