Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Issue 2820553002: Update preferred style of spelling enums. (Closed)

Created:
3 years, 8 months ago by Nico
Modified:
3 years, 8 months ago
Reviewers:
jbroman
CC:
chromium-reviews, danakj+watch_chromium.org, jbroman+cpp_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Update preferred style of spelling enums. As discussed here: https://groups.google.com/a/chromium.org/forum/#!topic/cxx/Hpkfudv5bac Chromium historically used FOO for enums. The Google styleguide eventually evolved into preferring kFoo instead (while allowing both). Since Blink now uses kFoo, and a few kFoos have snuck into Chromium's code base, remove this custom rule. BUG=711332 Review-Url: https://codereview.chromium.org/2820553002 Cr-Commit-Position: refs/heads/master@{#464447} Committed: https://chromium.googlesource.com/chromium/src/+/1262351d14e829049153dfe0b8f14b21c4b3b909

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M styleguide/c++/c++.md View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
Nico
3 years, 8 months ago (2017-04-13 16:24:34 UTC) #3
jbroman
lgtm
3 years, 8 months ago (2017-04-13 16:31:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2820553002/1
3 years, 8 months ago (2017-04-13 16:33:29 UTC) #8
commit-bot: I haz the power
3 years, 8 months ago (2017-04-13 17:13:59 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1262351d14e829049153dfe0b8f1...

Powered by Google App Engine
This is Rietveld 408576698