Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(528)

Unified Diff: styleguide/c++/c++.md

Issue 2820553002: Update preferred style of spelling enums. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: styleguide/c++/c++.md
diff --git a/styleguide/c++/c++.md b/styleguide/c++/c++.md
index e7af38be86bd1fa10d195835699108d24c2e186c..c7bb4916fbef0b5e3d5d0d0ce83b2ef20b5193e8 100644
--- a/styleguide/c++/c++.md
+++ b/styleguide/c++/c++.md
@@ -30,12 +30,6 @@ separate [C++11 use in Chromium](https://chromium-cpp.appspot.com/) page.
* "Chromium" is the name of the project, not the product, and should never
appear in code, variable names, API names etc. Use "Chrome" instead.
- * Though the Google C++ Style Guide now says to use `kConstantNaming` for
- enums, Chromium was written using `MACRO_STYLE` naming. In enums that are
- actually enumerations (i.e. have multiple values), continue to use this
- style for consistency. Use `kConstantNaming` when using the "enum hack" to
- define a single constant, as you would for a const int or the like.
-
* Functions used only for testing should be restricted to test-only scenarios
either by `#ifdefing` them appropriately (e.g. `#if defined(UNIT_TEST)`) or
by naming them with a `ForTesting` suffix. The latter will be checked at
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698