Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2820423003:
Add strings which will be used in new translate infobar. (Closed)
DescriptionAdd strings which will be used in new translate infobar.
Translate infobar strings docs:
https://docs.google.com/a/google.com/document/d/1eUFICgVyrM3cGtwvqOumeGss4677pXwLQ3NeR8BjoRg/edit?usp=sharing
BUG=703887
Review-Url: https://codereview.chromium.org/2820423003
Cr-Commit-Position: refs/heads/master@{#466204}
Committed: https://chromium.googlesource.com/chromium/src/+/806754212387f81494a459b0f7d5f5c56c142518
Patch Set 1 #Patch Set 2 : remove meaning #
Total comments: 7
Patch Set 3 : fix #Messages
Total messages: 15 (7 generated)
Description was changed from ========== Add strings which will be used in new translate infobar. BUG=703887 ========== to ========== Add strings which will be used in new translate infobar. Translate docs: https://docs.google.com/a/google.com/document/d/1eUFICgVyrM3cGtwvqOumeGss4677... BUG=703887 ==========
googleo@chromium.org changed reviewers: + dfalcantara@chromium.org, srahim@chromium.org
Hey Dan and Shimi, I added some texts which will be used later. Please take a look.
Description was changed from ========== Add strings which will be used in new translate infobar. Translate docs: https://docs.google.com/a/google.com/document/d/1eUFICgVyrM3cGtwvqOumeGss4677... BUG=703887 ========== to ========== Add strings which will be used in new translate infobar. Translate infobar strings docs: https://docs.google.com/a/google.com/document/d/1eUFICgVyrM3cGtwvqOumeGss4677... BUG=703887 ==========
Are you waiting for Shimi to approve these?
LGTM with suggested updates to message descriptions for translators. https://codereview.chromium.org/2820423003/diff/20001/chrome/android/java/str... File chrome/android/java/strings/android_chrome_strings.grd (right): https://codereview.chromium.org/2820423003/diff/20001/chrome/android/java/str... chrome/android/java/strings/android_chrome_strings.grd:1563: <message name="IDS_TRANSLATE_NEVER_TRANSLATE_LANGUAGE" desc="Text to display on the never translate language button. [CHAR-LIMIT=64]"> Please update message description: desc="Text that appears on a button. Chrome asks the user if they want to translate a page from the source language into another, target language that the user may have shown interest in before. User can click the "Never Translate" button to indicate that they never want Chrome to translate pages in this language. Imperative." https://codereview.chromium.org/2820423003/diff/20001/chrome/android/java/str... chrome/android/java/strings/android_chrome_strings.grd:1566: <message name="IDS_TRANSLATE_INFOBAR_MORE_LANGUAGE" desc="Menu item for selecting another target language to translate. [CHAR-LIMIT=64]"> Please revise message description, it's not quite right, according to my understand "More languages" offers the user other languages to choose from, if the default target language that Chrome has chosen based on the user's history is not what the user wants at this moment. desc="Option in the Chrome menu. Lets the user open a dialog to choose other target languages for translation, from a list of available languages." https://codereview.chromium.org/2820423003/diff/20001/chrome/android/java/str... chrome/android/java/strings/android_chrome_strings.grd:1572: <message name="IDS_TRANSLATE_SNACKBAR_ALWAYS_TRANSLATED" desc="Text to be displayed in translate snackbar that lets the user know pages in this source language will not be translated to target language automatically. [CHAR-LIMIT=64]"> Please check the message description. The message name is ALWAYS_TRANSLATED, and the string says "Sites in French will be translated to English". But the message description says "...pages in this source language will *not* be translated to target language automatically." I think the NOT should be removed, right? So it reads "...pages in this source language will be translated to target language automatically." Important so the translators don't get confused. https://codereview.chromium.org/2820423003/diff/20001/chrome/android/java/str... chrome/android/java/strings/android_chrome_strings.grd:1575: <message name="IDS_TRANSLATE_SNACKBAR_LANGUAGE_NEVER" desc="Text to be displayed in translate snackbar that lets the user know sites in this language not be translated. [CHAR-LIMIT=64]"> Minor nit in the message description so translators don't get confused: Add *will* "...lets the user know sites in this language *will* not be translated"
Thanks for the careful checking. Fixed all your comments. https://codereview.chromium.org/2820423003/diff/20001/chrome/android/java/str... File chrome/android/java/strings/android_chrome_strings.grd (right): https://codereview.chromium.org/2820423003/diff/20001/chrome/android/java/str... chrome/android/java/strings/android_chrome_strings.grd:1563: <message name="IDS_TRANSLATE_NEVER_TRANSLATE_LANGUAGE" desc="Text to display on the never translate language button. [CHAR-LIMIT=64]"> On 2017/04/20 04:33:17, srahim wrote: > Please update message description: > > desc="Text that appears on a button. Chrome asks the user if they want to > translate a page from the source language into another, target language that the > user may have shown interest in before. User can click the "Never Translate" > button to indicate that they never want Chrome to translate pages in this > language. Imperative." Desc is updated. This was the old translate info bar "Never translate *" Button. We reuse the same text in the new UI. But in the new UI, it's a menu option instead of button. Not sure whether we should modify the desc based on the context. https://codereview.chromium.org/2820423003/diff/20001/chrome/android/java/str... chrome/android/java/strings/android_chrome_strings.grd:1572: <message name="IDS_TRANSLATE_SNACKBAR_ALWAYS_TRANSLATED" desc="Text to be displayed in translate snackbar that lets the user know pages in this source language will not be translated to target language automatically. [CHAR-LIMIT=64]"> On 2017/04/20 04:33:17, srahim wrote: > Please check the message description. The message name is ALWAYS_TRANSLATED, and > the string says "Sites in French will be translated to English". But the message > description says "...pages in this source language will *not* be translated to > target language automatically." > > I think the NOT should be removed, right? So it reads "...pages in this source > language will be translated to target language automatically." > > Important so the translators don't get confused. Thanks for the catch. Fixed. https://codereview.chromium.org/2820423003/diff/20001/chrome/android/java/str... chrome/android/java/strings/android_chrome_strings.grd:1575: <message name="IDS_TRANSLATE_SNACKBAR_LANGUAGE_NEVER" desc="Text to be displayed in translate snackbar that lets the user know sites in this language not be translated. [CHAR-LIMIT=64]"> On 2017/04/20 04:33:17, srahim wrote: > Minor nit in the message description so translators don't get confused: Add > *will* > "...lets the user know sites in this language *will* not be translated" Thanks for the catch.
lgtm
The CQ bit was checked by googleo@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from srahim@chromium.org Link to the patchset: https://codereview.chromium.org/2820423003/#ps40001 (title: "fix")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1492733709844410,
"parent_rev": "822449eabd6f5c248beabea55fecc304f783d7a2", "commit_rev":
"806754212387f81494a459b0f7d5f5c56c142518"}
Message was sent while issue was closed.
Description was changed from ========== Add strings which will be used in new translate infobar. Translate infobar strings docs: https://docs.google.com/a/google.com/document/d/1eUFICgVyrM3cGtwvqOumeGss4677... BUG=703887 ========== to ========== Add strings which will be used in new translate infobar. Translate infobar strings docs: https://docs.google.com/a/google.com/document/d/1eUFICgVyrM3cGtwvqOumeGss4677... BUG=703887 Review-Url: https://codereview.chromium.org/2820423003 Cr-Commit-Position: refs/heads/master@{#466204} Committed: https://chromium.googlesource.com/chromium/src/+/806754212387f81494a459b0f7d5... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/806754212387f81494a459b0f7d5...
Message was sent while issue was closed.
FYI - this added 15KB to Chrome on Android. No action is required (unless you can think of an obvious way to reduce the overhead). https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fu... |
