Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Issue 2820333003: Revert of Communicate ExtensionSettings policy to renderers (Closed)

Created:
3 years, 8 months ago by vabr (Chromium)
Modified:
3 years, 8 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Communicate ExtensionSettings policy to renderers (patchset #19 id:500001 of https://codereview.chromium.org/2499493004/ ) Reason for revert: This likely broke MSan. Details in BUG=712641 Original issue's description: > Communicate ExtensionSettings policy to renderers > > -Communicate which hosts are runtime blocked to all renderers > -Blocks host permissions for specific hosts by specific extensions > -Tests via blocking content script injection > -Introduces new test class for use with ExtensionSettings policy > > BUG=624649 > > Review-Url: https://codereview.chromium.org/2499493004 > Cr-Commit-Position: refs/heads/master@{#464954} > Committed: https://chromium.googlesource.com/chromium/src/+/c2f02148125c69bdce012802d9a467d725965a93 TBR=dcheng@chromium.org,nrpeter@chromium.org,rdevlin.cronin@chromium.org,zmin@chromium.org,pastarmovj@chromium.org,nrpeter@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=624649 Review-Url: https://codereview.chromium.org/2820333003 Cr-Commit-Position: refs/heads/master@{#465230} Committed: https://chromium.googlesource.com/chromium/src/+/645e0abfe9d2c10a3a79756566e48f5440af70c7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -1015 lines) Patch
M chrome/browser/extensions/api/permissions/permissions_apitest.cc View 2 chunks +15 lines, -1 line 0 comments Download
M chrome/browser/extensions/content_script_apitest.cc View 2 chunks +0 lines, -14 lines 0 comments Download
M chrome/browser/extensions/extension_management.h View 1 chunk +2 lines, -20 lines 0 comments Download
M chrome/browser/extensions/extension_management.cc View 2 chunks +2 lines, -17 lines 0 comments Download
M chrome/browser/extensions/extension_management_constants.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_management_constants.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_management_internal.cc View 2 chunks +1 line, -10 lines 0 comments Download
M chrome/browser/extensions/extension_service.cc View 1 chunk +0 lines, -15 lines 0 comments Download
D chrome/browser/extensions/extension_with_management_policy_apitest.h View 1 chunk +0 lines, -29 lines 0 comments Download
D chrome/browser/extensions/extension_with_management_policy_apitest.cc View 1 chunk +0 lines, -21 lines 0 comments Download
M chrome/browser/extensions/permissions_updater.h View 4 chunks +0 lines, -25 lines 0 comments Download
M chrome/browser/extensions/permissions_updater.cc View 4 chunks +9 lines, -79 lines 0 comments Download
M chrome/browser/extensions/permissions_updater_unittest.cc View 3 chunks +0 lines, -107 lines 0 comments Download
M chrome/common/extensions/permissions/permissions_data_unittest.cc View 12 chunks +27 lines, -198 lines 0 comments Download
M chrome/test/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
D chrome/test/data/extensions/api_test/content_scripts/policy/background.js View 1 chunk +0 lines, -53 lines 0 comments Download
D chrome/test/data/extensions/api_test/content_scripts/policy/manifest.json View 1 chunk +0 lines, -7 lines 0 comments Download
M extensions/browser/renderer_startup_helper.cc View 2 chunks +0 lines, -10 lines 0 comments Download
M extensions/common/constants.h View 1 chunk +0 lines, -3 lines 0 comments Download
M extensions/common/constants.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M extensions/common/extension.h View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/common/extension_messages.h View 4 chunks +0 lines, -24 lines 0 comments Download
M extensions/common/extension_messages.cc View 8 chunks +4 lines, -34 lines 0 comments Download
M extensions/common/permissions/permissions_data.h View 5 chunks +0 lines, -81 lines 0 comments Download
M extensions/common/permissions/permissions_data.cc View 7 chunks +4 lines, -89 lines 0 comments Download
M extensions/common/url_pattern.h View 4 chunks +1 line, -24 lines 0 comments Download
M extensions/common/url_pattern.cc View 7 chunks +2 lines, -39 lines 0 comments Download
M extensions/common/url_pattern_unittest.cc View 17 chunks +33 lines, -81 lines 0 comments Download
M extensions/renderer/dispatcher.h View 2 chunks +0 lines, -3 lines 0 comments Download
M extensions/renderer/dispatcher.cc View 5 chunks +2 lines, -22 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
vabr (Chromium)
Created Revert of Communicate ExtensionSettings policy to renderers
3 years, 8 months ago (2017-04-18 14:25:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2820333003/1
3 years, 8 months ago (2017-04-18 14:25:27 UTC) #3
commit-bot: I haz the power
3 years, 8 months ago (2017-04-18 14:27:59 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/645e0abfe9d2c10a3a79756566e4...

Powered by Google App Engine
This is Rietveld 408576698