Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1192)

Unified Diff: extensions/common/url_pattern.cc

Issue 2820333003: Revert of Communicate ExtensionSettings policy to renderers (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/common/url_pattern.h ('k') | extensions/common/url_pattern_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/common/url_pattern.cc
diff --git a/extensions/common/url_pattern.cc b/extensions/common/url_pattern.cc
index dba84a529cae21c7b2dd9d0303fd45ad458498ce..5677fbc8367682015aea8baff570c266e0815fc9 100644
--- a/extensions/common/url_pattern.cc
+++ b/extensions/common/url_pattern.cc
@@ -141,14 +141,12 @@
: valid_schemes_(SCHEME_NONE),
match_all_urls_(false),
match_subdomains_(false),
- match_effective_tld_(true),
port_("*") {}
URLPattern::URLPattern(int valid_schemes)
: valid_schemes_(valid_schemes),
match_all_urls_(false),
match_subdomains_(false),
- match_effective_tld_(true),
port_("*") {}
URLPattern::URLPattern(int valid_schemes, base::StringPiece pattern)
@@ -157,7 +155,6 @@
: valid_schemes_(valid_schemes),
match_all_urls_(false),
match_subdomains_(false),
- match_effective_tld_(true),
port_("*") {
ParseResult result = Parse(pattern);
if (PARSE_SUCCESS != result)
@@ -186,15 +183,9 @@
}
URLPattern::ParseResult URLPattern::Parse(base::StringPiece pattern) {
- return Parse(pattern, DENY_WILDCARD_FOR_EFFECTIVE_TLD);
-}
-
-URLPattern::ParseResult URLPattern::Parse(base::StringPiece pattern,
- ParseOptions parse_options) {
spec_.clear();
SetMatchAllURLs(false);
SetMatchSubdomains(false);
- SetMatchEffectiveTld(true);
SetPort("*");
// Special case pattern to match every valid URL.
@@ -276,14 +267,6 @@
host_components.erase(host_components.begin(),
host_components.begin() + 1);
}
-
- // If explicitly allowed, the last component can optionally be '*' to
- // match all effective TLDs.
- if (parse_options == ALLOW_WILDCARD_FOR_EFFECTIVE_TLD &&
- host_components.size() > 1 && host_components.back() == "*") {
- match_effective_tld_ = false;
- host_components.pop_back();
- }
host_ = base::JoinString(host_components, ".");
path_start_pos = host_end_pos;
@@ -338,11 +321,6 @@
match_subdomains_ = val;
}
-void URLPattern::SetMatchEffectiveTld(bool val) {
- spec_.clear();
- match_effective_tld_ = val;
-}
-
bool URLPattern::SetScheme(base::StringPiece scheme) {
spec_.clear();
scheme.CopyToString(&scheme_);
@@ -443,18 +421,9 @@
}
bool URLPattern::MatchesHost(const GURL& test) const {
- base::StringPiece test_host(CanonicalizeHostForMatching(test.host_piece()));
+ const base::StringPiece test_host(
+ CanonicalizeHostForMatching(test.host_piece()));
const base::StringPiece pattern_host(CanonicalizeHostForMatching(host_));
-
- // If we don't care about matching the effective TLD, remove it.
- if (!match_effective_tld_) {
- int reg_length = net::registry_controlled_domains::GetRegistryLength(
- test, net::registry_controlled_domains::EXCLUDE_UNKNOWN_REGISTRIES,
- net::registry_controlled_domains::EXCLUDE_PRIVATE_REGISTRIES);
- if (reg_length > 0) {
- test_host = test_host.substr(0, test_host.size() - reg_length - 1);
- }
- }
// If the hosts are exactly equal, we have a match.
if (test_host == pattern_host)
@@ -560,12 +529,6 @@
if (!host_.empty())
spec += host_;
- if (!match_effective_tld_) {
- if (!host_.empty())
- spec += ".";
- spec += "*";
- }
-
if (port_ != "*") {
spec += ":";
spec += port_;
« no previous file with comments | « extensions/common/url_pattern.h ('k') | extensions/common/url_pattern_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698