Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(551)

Issue 2820273004: Revert of Remove PaintCanvas::getBaseLayerSize. (Closed)

Created:
3 years, 8 months ago by findit-for-me
Modified:
3 years, 8 months ago
CC:
cc-bugs_chromium.org, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove PaintCanvas::getBaseLayerSize. (patchset #1 id:1 of https://codereview.chromium.org/2823253004/ ) Reason for revert: Findit(https://goo.gl/kROfz5) identified CL at revision 465423 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2VmYTM5OTlmNzZlODIyY2M5NTgwY2FjZTQ5OGYzZjc3ODIwNmE5ZGMM Original issue's description: > Remove PaintCanvas::getBaseLayerSize. > > The method is now unused. > > R=enne@chromium.org > BUG=671433 > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel > > Review-Url: https://codereview.chromium.org/2823253004 > Cr-Commit-Position: refs/heads/master@{#465423} > Committed: https://chromium.googlesource.com/chromium/src/+/efa3999f76e822cc9580cace498f3f778206a9dc TBR=enne@chromium.org,danakj@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=671433 Review-Url: https://codereview.chromium.org/2820273004 Cr-Commit-Position: refs/heads/master@{#465427} Committed: https://chromium.googlesource.com/chromium/src/+/45438484dd3e094951bfbdad9ebd6687933c7840

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M cc/paint/paint_canvas.h View 1 chunk +1 line, -0 lines 0 comments Download
M cc/paint/skia_paint_canvas.h View 1 chunk +1 line, -0 lines 0 comments Download
M cc/paint/skia_paint_canvas.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
findit-for-me
Created Revert of Remove PaintCanvas::getBaseLayerSize.
3 years, 8 months ago (2017-04-18 23:53:51 UTC) #1
findit-for-me
Sheriffs: Please confirm and "Quick L-G-T-M & CQ" this revert if it is correct. If ...
3 years, 8 months ago (2017-04-18 23:53:52 UTC) #3
ojan
lgtm
3 years, 8 months ago (2017-04-18 23:57:03 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2820273004/1
3 years, 8 months ago (2017-04-18 23:57:43 UTC) #7
commit-bot: I haz the power
3 years, 8 months ago (2017-04-18 23:58:31 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/45438484dd3e094951bfbdad9ebd...

Powered by Google App Engine
This is Rietveld 408576698