In QUIC version >= 38, enables random padding of size [1, 256]

net/quic/quartc/quartc_stream_test.cc

 // Copyright (c) 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/quic/quartc/quartc_stream.h"
 
 #include "base/threading/thread_task_runner_handle.h"
 #include "net/quic/core/crypto/quic_random.h"
 #include "net/quic/core/quic_session.h"
 #include "net/quic/core/quic_simple_buffer_allocator.h"
@@ skipping 19 matching lines @@
                   std::string* write_buffer)
       : QuicSession(connection, nullptr /*visitor*/, config),
         write_buffer_(write_buffer) {}
 
   // Writes outgoing data from QuicStream to a string.
   QuicConsumedData WritevData(
       QuicStream* stream,
       QuicStreamId id,
       QuicIOVector iovector,
       QuicStreamOffset offset,
-      bool fin,
+      StreamSendingState fin,
       QuicReferenceCountedPointer<
           QuicAckListenerInterface> /*ack_notifier_delegate*/) override {
     if (!writable_) {
       return QuicConsumedData(0, false);
     }
 
     const char* data = reinterpret_cast<const char*>(iovector.iov->iov_base);
     size_t len = iovector.total_length;
     write_buffer_->append(data, len);
     return QuicConsumedData(len, fin);

[Zhongyi Shi, 2017/04/18 22:17:56]

QuicConsumedData constructor should takes a boolean rather than a Enum, does
this patch compile successfully?

[Ryan Hamilton, 2017/04/18 22:49:36]

It does... but probably by accident :/ Fixed in the Final CL.

   }
 
   QuartcStream* CreateIncomingDynamicStream(QuicStreamId id) override {
     return nullptr;
   }
 
   QuartcStream* CreateOutgoingDynamicStream(SpdyPriority priority) override {
     return nullptr;
   }
 
@@ skipping 196 matching lines @@
 TEST_F(QuartcStreamTest, CloseStream) {
   CreateReliableQuicStream();
   EXPECT_FALSE(mock_stream_delegate_->closed());
   stream_->OnClose();
   EXPECT_TRUE(mock_stream_delegate_->closed());
 }
 
 }  // namespace
 }  // namespace test
 }  // namespace net