Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1947)

Unified Diff: net/quic/core/quic_headers_stream_test.cc

Issue 2820263005: In QUIC version >= 38, enables random padding of size [1, 256] (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/quic/core/quic_headers_stream_test.cc
diff --git a/net/quic/core/quic_headers_stream_test.cc b/net/quic/core/quic_headers_stream_test.cc
index f1f4816cdf8b968558be003d37c510fadcc2c207..b20358b76bcbf95868a9181513d27090f3a6f655 100644
--- a/net/quic/core/quic_headers_stream_test.cc
+++ b/net/quic/core/quic_headers_stream_test.cc
@@ -317,7 +317,7 @@ class QuicHeadersStreamTest : public ::testing::TestWithParam<TestParamsTuple> {
bool is_request) {
// Write the headers and capture the outgoing data
EXPECT_CALL(session_,
- WritevData(headers_stream_, kHeadersStreamId, _, _, false, _))
+ WritevData(headers_stream_, kHeadersStreamId, _, _, NO_FIN, _))
.WillOnce(WithArgs<2>(Invoke(this, &QuicHeadersStreamTest::SaveIov)));
QuicSpdySessionPeer::WriteHeadersImpl(
&session_, stream_id, headers_.Clone(), fin, priority, nullptr);
@@ -433,8 +433,8 @@ TEST_P(QuicHeadersStreamTest, WritePushPromises) {
QuicStreamId promised_stream_id = NextPromisedStreamId();
if (perspective() == Perspective::IS_SERVER) {
// Write the headers and capture the outgoing data
- EXPECT_CALL(session_,
- WritevData(headers_stream_, kHeadersStreamId, _, _, false, _))
+ EXPECT_CALL(session_, WritevData(headers_stream_, kHeadersStreamId, _, _,
+ NO_FIN, _))
.WillOnce(WithArgs<2>(Invoke(this, &QuicHeadersStreamTest::SaveIov)));
session_.WritePushPromise(stream_id, promised_stream_id,
headers_.Clone());
@@ -943,8 +943,8 @@ TEST_P(QuicHeadersStreamTest, WritevStreamData) {
if (use_ack_listener) {
ack_listener = new ForceHolAckListener();
}
- EXPECT_CALL(session_,
- WritevData(headers_stream_, kHeadersStreamId, _, _, false, _))
+ EXPECT_CALL(session_, WritevData(headers_stream_, kHeadersStreamId, _, _,
+ NO_FIN, _))
.WillRepeatedly(WithArgs<2, 5>(Invoke(
this, &QuicHeadersStreamTest::SaveIovAndNotifyAckListener)));
@@ -982,7 +982,7 @@ TEST_P(QuicHeadersStreamTest, WritevStreamDataFinOnly) {
string data;
EXPECT_CALL(session_,
- WritevData(headers_stream_, kHeadersStreamId, _, _, false, _))
+ WritevData(headers_stream_, kHeadersStreamId, _, _, NO_FIN, _))
.WillOnce(WithArgs<2, 5>(
Invoke(this, &QuicHeadersStreamTest::SaveIovAndNotifyAckListener)));
@@ -1014,7 +1014,7 @@ TEST_P(QuicHeadersStreamTest, WritevStreamDataSendBlocked) {
// In that case, |WritevStreamData| should consume just one
// HTTP/2 data frame's worth of data.
EXPECT_CALL(session_,
- WritevData(headers_stream_, kHeadersStreamId, _, _, false, _))
+ WritevData(headers_stream_, kHeadersStreamId, _, _, NO_FIN, _))
.WillOnce(
WithArgs<2>(Invoke(this, &QuicHeadersStreamTest::SaveIovShort)));

Powered by Google App Engine
This is Rietveld 408576698