Always report maybe-clipped when painting fragmented content

Always report maybe-clipped when painting fragmented content.

We already disable display list caching for this content. This CL
also effectively disables subsequence caching.

Also removed some now-unneeded under-invalidation code in PaintController
(unneeded since https://codereview.chromium.org/2768143002) and improved
a comment.

BUG=709846
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2820233002
Cr-Commit-Position: refs/heads/master@{#465660}
Committed: https://chromium.googlesource.com/chromium/src/+/3596d8b9d1adad8ffe958b500f2729fcae7270e4

[chrishtr, 2017-04-17 23:49:58]

Description was changed from

==========
none


none


none


none


none


none


none

BUG=
==========

to

==========
none


none


none


none


none


none


none

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[chrishtr, 2017-04-18 00:04:13]

Description was changed from

==========
none


none


none


none


none


none


none

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Always report maybe-clipped when painting fragmented content.

We already disable display list caching for this content. This CL
also effectively disables subsequence caching.


BUG=709846
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[chrishtr, 2017-04-18 00:05:55]

Description was changed from

==========
Always report maybe-clipped when painting fragmented content.

We already disable display list caching for this content. This CL
also effectively disables subsequence caching.


BUG=709846
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Always report maybe-clipped when painting fragmented content.

We already disable display list caching for this content. This CL
also effectively disables subsequence caching.

Also removed some now-unneeded under-invalidation code in PaintController
(unneeded since https://codereview.chromium.org/2768143002) and improved
a comment.

BUG=709846
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[chrishtr, 2017-04-18 00:06:14]

The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-18 00:06:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[chrishtr, 2017-04-18 00:07:03]

chrishtr@chromium.org changed reviewers:
+ wangxianzhu@chromium.org

[chrishtr, 2017-04-18 00:07:04]

The alternative to this CL is to plumb whether the dirty rect had any effect
through to the fragmentation and PaintLayerClipper code. I judged that more
effort than it is worth right now.

[chrishtr, 2017-04-18 00:07:10]

chrishtr@chromium.org changed reviewers:
- wangxianzhu@chromium.org

[Xianzhu, 2017-04-18 00:15:20]

wangxianzhu@chromium.org changed reviewers:
+ wangxianzhu@chromium.org

[Xianzhu, 2017-04-18 00:15:21]

https://codereview.chromium.org/2820233002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/paint/pagination/pagination-change-clip-crash.html
(right):

https://codereview.chromium.org/2820233002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/paint/pagination/pagination-change-clip-crash.html:15:
window.internals.runtimeFlags.paintUnderInvalidationCheckingEnabled = true;
This is unnecessary because we always check for under-invalidation for
text-based-repaint tests.

https://codereview.chromium.org/2820233002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/paint/pagination/pagination-change-clip-crash.html:17:
window.testRunner.waitUntilDone();
Similar.

https://codereview.chromium.org/2820233002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/paint/pagination/pagination-change-clip-crash.html:20:
window.requestAnimationFrame(function() {
Is requestAnimationFrame necessary?

https://codereview.chromium.org/2820233002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/paint/pagination/pagination-change-clip-crash.html:28:
<div class="composited" style="height:200px" id="background">
Put all dom elements together (not separated by style and script). It might also
look better to inline the composited class style.

https://codereview.chromium.org/2820233002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp
(left):

https://codereview.chromium.org/2820233002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp:886:
++skipped_probable_under_invalidation_count_;
Doesn't the logic apply now?

[commit-bot: I haz the power, 2017-04-18 01:42:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-18 01:42:33]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[chrishtr, 2017-04-18 21:13:14]

https://codereview.chromium.org/2820233002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/paint/pagination/pagination-change-clip-crash.html
(right):

https://codereview.chromium.org/2820233002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/paint/pagination/pagination-change-clip-crash.html:15:
window.internals.runtimeFlags.paintUnderInvalidationCheckingEnabled = true;
On 2017/04/18 at 00:15:21, Xianzhu wrote:
> This is unnecessary because we always check for under-invalidation for
text-based-repaint tests.

Done.

https://codereview.chromium.org/2820233002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/paint/pagination/pagination-change-clip-crash.html:17:
window.testRunner.waitUntilDone();
On 2017/04/18 at 00:15:21, Xianzhu wrote:
> Similar.

Done.

https://codereview.chromium.org/2820233002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/paint/pagination/pagination-change-clip-crash.html:20:
window.requestAnimationFrame(function() {
On 2017/04/18 at 00:15:21, Xianzhu wrote:
> Is requestAnimationFrame necessary?

Done. Good catches.
I seemed to need these in an earlier version of the test, but they are not
needed now.

https://codereview.chromium.org/2820233002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/paint/pagination/pagination-change-clip-crash.html:28:
<div class="composited" style="height:200px" id="background">
On 2017/04/18 at 00:15:21, Xianzhu wrote:
> Put all dom elements together (not separated by style and script). It might
also look better to inline the composited class style.

Done.

https://codereview.chromium.org/2820233002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp
(left):

https://codereview.chromium.org/2820233002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp:886:
++skipped_probable_under_invalidation_count_;
On 2017/04/18 at 00:15:21, Xianzhu wrote:
> Doesn't the logic apply now?

It doesn't, because the folding optimization in CompositingRecorder is now gone,
right?

However, that CL was reverted again yesterday, so re-adding this code for now.

[chrishtr, 2017-04-18 21:13:17]

The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-18 21:13:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xianzhu, 2017-04-18 21:16:13]

lgtm

[commit-bot: I haz the power, 2017-04-18 22:54:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-18 22:54:21]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[chrishtr, 2017-04-18 23:19:17]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2017-04-18 23:19:18]

The patchset sent to the CQ was uploaded after l-g-t-m from
wangxianzhu@chromium.org
Link to the patchset: https://codereview.chromium.org/2820233002/#ps40001
(title: "none")

[commit-bot: I haz the power, 2017-04-18 23:19:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-19 01:11:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-19 01:11:29]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[chrishtr, 2017-04-19 16:05:13]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2017-04-19 16:05:13]

The patchset sent to the CQ was uploaded after l-g-t-m from
wangxianzhu@chromium.org
Link to the patchset: https://codereview.chromium.org/2820233002/#ps60001
(title: "none")

[commit-bot: I haz the power, 2017-04-19 16:05:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-19 17:41:59]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1492617913302050,
"parent_rev": "31019d751c35578034f6bf1f37467c8aa9ffff70", "commit_rev":
"3596d8b9d1adad8ffe958b500f2729fcae7270e4"}

[commit-bot: I haz the power, 2017-04-19 17:42:08]

Description was changed from

==========
Always report maybe-clipped when painting fragmented content.

We already disable display list caching for this content. This CL
also effectively disables subsequence caching.

Also removed some now-unneeded under-invalidation code in PaintController
(unneeded since https://codereview.chromium.org/2768143002) and improved
a comment.

BUG=709846
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Always report maybe-clipped when painting fragmented content.

We already disable display list caching for this content. This CL
also effectively disables subsequence caching.

Also removed some now-unneeded under-invalidation code in PaintController
(unneeded since https://codereview.chromium.org/2768143002) and improved
a comment.

BUG=709846
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2820233002
Cr-Commit-Position: refs/heads/master@{#465660}
Committed:
https://chromium.googlesource.com/chromium/src/+/3596d8b9d1adad8ffe958b500f27...
==========

[commit-bot: I haz the power, 2017-04-19 17:42:09]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/3596d8b9d1adad8ffe958b500f27...