third_party/WebKit/LayoutTests/paint/pagination/pagination-change-clip-crash.html - Issue 2820233002: Always report maybe-clipped when painting fragmented content

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/paint/pagination/pagination-change-clip-crash.html

Issue 2820233002: Always report maybe-clipped when painting fragmented content (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!doctype HTML>

	2 <script src="../invalidation/resources/text-based-repaint.js"></script>

	3 <div id=multicol style="columns:3;">

	4 <div style="height:300px; background:white;">

	5 </div>

	6 </div>

	7 <div style="width: 10px; height: 300px"></div>

	8 <style>

	9 .composited {

	10 transform: translateZ(0);

	11 }

	12 </style>

	13 <script>

	14 if (window.internals)

	15 window.internals.runtimeFlags.paintUnderInvalidationCheckingEnabled = true;
	Xianzhu 2017/04/18 00:15:21 This is unnecessary because we always check for un This is unnecessary because we always check for under-invalidation for text-based-repaint tests. chrishtr 2017/04/18 21:13:13 Done. Show quoted text On 2017/04/18 at 00:15:21, Xianzhu wrote: > This is unnecessary because we always check for under-invalidation for text-based-repaint tests. Done.
	16 if (window.testRunner)

	17 window.testRunner.waitUntilDone();
	Xianzhu 2017/04/18 00:15:21 Similar. Similar. chrishtr 2017/04/18 21:13:13 Done. Show quoted text On 2017/04/18 at 00:15:21, Xianzhu wrote: > Similar. Done.
	18

	19 function repaintTest() {

	20 window.requestAnimationFrame(function() {
	Xianzhu 2017/04/18 00:15:21 Is requestAnimationFrame necessary? Is requestAnimationFrame necessary? chrishtr 2017/04/18 21:13:13 Done. Good catches. I seemed to need these in an e Show quoted text On 2017/04/18 at 00:15:21, Xianzhu wrote: > Is requestAnimationFrame necessary? Done. Good catches. I seemed to need these in an earlier version of the test, but they are not needed now.
	21 background.style.padding = "50px";

	22 });

	23 }

	24

	25 window.testIsAsync = true;

	26 onload = runRepaintTest;

	27 </script>

	28 <div class="composited" style="height:200px" id="background">
	Xianzhu 2017/04/18 00:15:21 Put all dom elements together (not separated by st Put all dom elements together (not separated by style and script). It might also look better to inline the composited class style. chrishtr 2017/04/18 21:13:13 Done. Show quoted text On 2017/04/18 at 00:15:21, Xianzhu wrote: > Put all dom elements together (not separated by style and script). It might also look better to inline the composited class style. Done.
OLD	NEW