Revert of Back PaintRecord with PaintOpBuffer instead of SkPicture

Revert of Back PaintRecord with PaintOpBuffer instead of SkPicture (patchset #42 id:810001 of https://codereview.chromium.org/2768143002/ )

Reason for revert:
Reverting due to CrOS breakage.
crbug.com/712102


Original issue's description:
> Back PaintRecord with PaintOpBuffer instead of SkPicture
> 
> Change the backing of PaintRecord to be a data structure implemented in
> cc/paint instead of using SkPicture directly.  This new class cribs heavily
> from SkLiteDL.
> 
> PaintRecord used to be a typedef to an SkPicture but now is a typedef to
> a PaintOpBuffer.  (This leaves some flexibility to change this in the
> future to an interface without having to modify all of Chromium again.)
> 
> PaintOpBuffer stores a contiguous array of ops, with the ops stored
> in place.  As an optimization, the first op is stored locally in the
> PaintOpBuffer itself to avoid extra allocations for small pictures.
> 
> This patch moves slow path counting from a gpu analysis canvas into
> PaintOpBuffer directly.  As ops are recorded, slow paths are counted, and
> a PaintRecord now knows how many ops it has.  This is about a 1.5% savings
> for record time (gpu analysis was 2% and 0.5% overhead to record later).
> 
> This patch also implements the SkRecordNoopSaveLayerDrawRestores
> optimization from Skia at raster time.  This takes save layer (just
> opacity) / draw / restore commands and turns them into draws with
> opacity.  It moves that optimization from Blink at record time inside of
> CompositingRecorder and moves it to both DisplayItemList::RasterItem
> and PaintOpBuffer::playback (since a save could be either a DisplayItem
> or a PaintOp).  It's not as robust as Skia's solution and so misses
> a few cases that Skia catches, but the rasterize and record on 10k
> page agreed that performance was good enough.
> 
> CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> 
> Review-Url: https://codereview.chromium.org/2768143002
> Cr-Commit-Position: refs/heads/master@{#464809}
> Committed: https://chromium.googlesource.com/chromium/src/+/e49d70a44bf12043cc781390f7fc53ce7b4ac807

TBR=chrishtr@chromium.org,danakj@chromium.org,mtklein@chromium.org,thakis@chromium.org,vitalybuka@chromium.org,vmpstr@chromium.org,enne@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.

Review-Url: https://codereview.chromium.org/2820133005
Cr-Commit-Position: refs/heads/master@{#465196}
Committed: https://chromium.googlesource.com/chromium/src/+/ddefb10bee663f8d240c999309f37cc2f96d2e92

[hidehiko, 2017-04-18 09:32:10]

The CQ bit was checked by hidehiko@chromium.org

[hidehiko, 2017-04-18 09:32:11]

Created Revert of Back PaintRecord with PaintOpBuffer instead of SkPicture

[commit-bot: I haz the power, 2017-04-18 09:32:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-18 11:14:57]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1492507930824760, "parent_rev":
"c5c4df9a8c8fabb131dd92a11f30843319942dee", "commit_rev":
"ddefb10bee663f8d240c999309f37cc2f96d2e92"}

[commit-bot: I haz the power, 2017-04-18 11:15:09]

Description was changed from

==========
Revert of Back PaintRecord with PaintOpBuffer instead of SkPicture (patchset #42
id:810001 of https://codereview.chromium.org/2768143002/ )

Reason for revert:
Reverting due to CrOS breakage.
crbug.com/712102


Original issue's description:
> Back PaintRecord with PaintOpBuffer instead of SkPicture
> 
> Change the backing of PaintRecord to be a data structure implemented in
> cc/paint instead of using SkPicture directly.  This new class cribs heavily
> from SkLiteDL.
> 
> PaintRecord used to be a typedef to an SkPicture but now is a typedef to
> a PaintOpBuffer.  (This leaves some flexibility to change this in the
> future to an interface without having to modify all of Chromium again.)
> 
> PaintOpBuffer stores a contiguous array of ops, with the ops stored
> in place.  As an optimization, the first op is stored locally in the
> PaintOpBuffer itself to avoid extra allocations for small pictures.
> 
> This patch moves slow path counting from a gpu analysis canvas into
> PaintOpBuffer directly.  As ops are recorded, slow paths are counted, and
> a PaintRecord now knows how many ops it has.  This is about a 1.5% savings
> for record time (gpu analysis was 2% and 0.5% overhead to record later).
> 
> This patch also implements the SkRecordNoopSaveLayerDrawRestores
> optimization from Skia at raster time.  This takes save layer (just
> opacity) / draw / restore commands and turns them into draws with
> opacity.  It moves that optimization from Blink at record time inside of
> CompositingRecorder and moves it to both DisplayItemList::RasterItem
> and PaintOpBuffer::playback (since a save could be either a DisplayItem
> or a PaintOp).  It's not as robust as Skia's solution and so misses
> a few cases that Skia catches, but the rasterize and record on 10k
> page agreed that performance was good enough.
> 
>
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> 
> Review-Url: https://codereview.chromium.org/2768143002
> Cr-Commit-Position: refs/heads/master@{#464809}
> Committed:
https://chromium.googlesource.com/chromium/src/+/e49d70a44bf12043cc781390f7fc...

TBR=chrishtr@chromium.org,danakj@chromium.org,mtklein@chromium.org,thakis@chr...
# Not skipping CQ checks because original CL landed more than 1 days ago.
==========

to

==========
Revert of Back PaintRecord with PaintOpBuffer instead of SkPicture (patchset #42
id:810001 of https://codereview.chromium.org/2768143002/ )

Reason for revert:
Reverting due to CrOS breakage.
crbug.com/712102


Original issue's description:
> Back PaintRecord with PaintOpBuffer instead of SkPicture
> 
> Change the backing of PaintRecord to be a data structure implemented in
> cc/paint instead of using SkPicture directly.  This new class cribs heavily
> from SkLiteDL.
> 
> PaintRecord used to be a typedef to an SkPicture but now is a typedef to
> a PaintOpBuffer.  (This leaves some flexibility to change this in the
> future to an interface without having to modify all of Chromium again.)
> 
> PaintOpBuffer stores a contiguous array of ops, with the ops stored
> in place.  As an optimization, the first op is stored locally in the
> PaintOpBuffer itself to avoid extra allocations for small pictures.
> 
> This patch moves slow path counting from a gpu analysis canvas into
> PaintOpBuffer directly.  As ops are recorded, slow paths are counted, and
> a PaintRecord now knows how many ops it has.  This is about a 1.5% savings
> for record time (gpu analysis was 2% and 0.5% overhead to record later).
> 
> This patch also implements the SkRecordNoopSaveLayerDrawRestores
> optimization from Skia at raster time.  This takes save layer (just
> opacity) / draw / restore commands and turns them into draws with
> opacity.  It moves that optimization from Blink at record time inside of
> CompositingRecorder and moves it to both DisplayItemList::RasterItem
> and PaintOpBuffer::playback (since a save could be either a DisplayItem
> or a PaintOp).  It's not as robust as Skia's solution and so misses
> a few cases that Skia catches, but the rasterize and record on 10k
> page agreed that performance was good enough.
> 
>
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> 
> Review-Url: https://codereview.chromium.org/2768143002
> Cr-Commit-Position: refs/heads/master@{#464809}
> Committed:
https://chromium.googlesource.com/chromium/src/+/e49d70a44bf12043cc781390f7fc...

TBR=chrishtr@chromium.org,danakj@chromium.org,mtklein@chromium.org,thakis@chr...
# Not skipping CQ checks because original CL landed more than 1 days ago.

Review-Url: https://codereview.chromium.org/2820133005
Cr-Commit-Position: refs/heads/master@{#465196}
Committed:
https://chromium.googlesource.com/chromium/src/+/ddefb10bee663f8d240c999309f3...
==========

[commit-bot: I haz the power, 2017-04-18 11:15:10]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ddefb10bee663f8d240c999309f3...