Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1205)

Unified Diff: third_party/WebKit/Source/platform/graphics/paint/PaintControllerTest.cpp

Issue 2820133005: Revert of Back PaintRecord with PaintOpBuffer instead of SkPicture (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/graphics/paint/PaintControllerTest.cpp
diff --git a/third_party/WebKit/Source/platform/graphics/paint/PaintControllerTest.cpp b/third_party/WebKit/Source/platform/graphics/paint/PaintControllerTest.cpp
index 5a09e2d8edd67cbbfd1cc59229bf53a681efe1bc..f4e0aae5f8622da9df772f58d4ea9a744c220552 100644
--- a/third_party/WebKit/Source/platform/graphics/paint/PaintControllerTest.cpp
+++ b/third_party/WebKit/Source/platform/graphics/paint/PaintControllerTest.cpp
@@ -2273,6 +2273,40 @@
DisplayItemClient::EndShouldKeepAliveAllClients();
#endif
}
+
+ void TestFoldCompositingDrawingInSubsequence() {
+ FakeDisplayItemClient container("container");
+ FakeDisplayItemClient content("content");
+ GraphicsContext context(GetPaintController());
+
+ {
+ SubsequenceRecorder subsequence(context, container);
+ CompositingRecorder compositing(context, content, SkBlendMode::kSrc, 0.5);
+ DrawRect(context, content, kBackgroundDrawingType,
+ FloatRect(100, 100, 300, 300));
+ }
+ GetPaintController().CommitNewDisplayItems();
+ EXPECT_EQ(
+ 1u,
+ GetPaintController().GetPaintArtifact().GetDisplayItemList().size());
+
+ {
+ EXPECT_FALSE(SubsequenceRecorder::UseCachedSubsequenceIfPossible(
+ context, container));
+ SubsequenceRecorder subsequence(context, container);
+ CompositingRecorder compositing(context, content, SkBlendMode::kSrc, 0.5);
+ DrawRect(context, content, kBackgroundDrawingType,
+ FloatRect(100, 100, 300, 300));
+ }
+ GetPaintController().CommitNewDisplayItems();
+ EXPECT_EQ(
+ 1u,
+ GetPaintController().GetPaintArtifact().GetDisplayItemList().size());
+
+#if CHECK_DISPLAY_ITEM_CLIENT_ALIVENESS
+ DisplayItemClient::EndShouldKeepAliveAllClients();
+#endif
+ }
};
TEST_F(PaintControllerUnderInvalidationTest, ChangeDrawing) {
@@ -2322,6 +2356,11 @@
TestInvalidationInSubsequence();
}
+TEST_F(PaintControllerUnderInvalidationTest,
+ FoldCompositingDrawingInSubsequence) {
+ TestFoldCompositingDrawingInSubsequence();
+}
+
#endif // defined(GTEST_HAS_DEATH_TEST) && !OS(ANDROID)
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698