Remove AudioBufferCallback

Remove AudioBufferCallback

According to the WebAudio spec, the AudioBufferCallback interface
should not exist.  Instead we should have a DecodeSuccessCallback and
DecodeErrorCallback functions.

BUG=707338
TEST=callback behavior covered by existing tests

Review-Url: https://codereview.chromium.org/2820113006
Cr-Commit-Position: refs/heads/master@{#466363}
Committed: https://chromium.googlesource.com/chromium/src/+/91e558ce715fc5990700cfd003084b6c4a8ed3fa

[Raymond Toy, 2017-04-19 15:17:50]

rtoy@chromium.org changed reviewers:
+ foolip@chromium.org, hongchan@chromium.org

[Raymond Toy, 2017-04-19 15:17:51]

PTAL

[hongchan, 2017-04-19 15:40:11]

lgtm

[jsbell, 2017-04-19 17:23:13]

jsbell@chromium.org changed reviewers:
+ jsbell@chromium.org

[jsbell, 2017-04-19 17:23:14]

drive-by...

https://codereview.chromium.org/2820113006/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/webaudio/BaseAudioContext.idl (right):

https://codereview.chromium.org/2820113006/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/webaudio/BaseAudioContext.idl:7: callback
DecodeSuccessCallback = void (AudioBuffer decodedData);
totally silly nit: If you move these down below the enum, and put Error above
Success the order will match the sec.

[foolip, 2017-04-20 11:32:51]

lgtm

https://codereview.chromium.org/2820113006/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/webaudio/BaseAudioContext.cpp (right):

https://codereview.chromium.org/2820113006/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/webaudio/BaseAudioContext.cpp:313:
error_callback->call(this, error);
Oh, sweet, using callback functions didn't used to be this simple :)

https://codereview.chromium.org/2820113006/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/webaudio/BaseAudioContext.idl (right):

https://codereview.chromium.org/2820113006/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/webaudio/BaseAudioContext.idl:7: callback
DecodeSuccessCallback = void (AudioBuffer decodedData);
On 2017/04/19 17:23:14, jsbell wrote:
> totally silly nit: If you move these down below the enum, and put Error above
> Success the order will match the sec. 

FWIW, I like it when the order matches the spec too.

[Raymond Toy, 2017-04-20 15:20:41]

https://codereview.chromium.org/2820113006/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/webaudio/BaseAudioContext.cpp (right):

https://codereview.chromium.org/2820113006/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/webaudio/BaseAudioContext.cpp:313:
error_callback->call(this, error);
On 2017/04/20 11:32:50, foolip_UTC7 wrote:
> Oh, sweet, using callback functions didn't used to be this simple :)

Not actually 100% sure about this; I inspected the generated v8 bindings code,
found a method called |call| that had a DOMException parameter.

[Raymond Toy, 2017-04-20 15:21:40]

https://codereview.chromium.org/2820113006/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/webaudio/BaseAudioContext.idl (right):

https://codereview.chromium.org/2820113006/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/webaudio/BaseAudioContext.idl:7: callback
DecodeSuccessCallback = void (AudioBuffer decodedData);
On 2017/04/20 11:32:50, foolip_UTC7 wrote:
> On 2017/04/19 17:23:14, jsbell wrote:
> > totally silly nit: If you move these down below the enum, and put Error
above
> > Success the order will match the sec. 
> 
> FWIW, I like it when the order matches the spec too.

Done.

[Raymond Toy, 2017-04-20 15:22:28]

Description was changed from

==========
Remove AudioBufferCallback

According to the WebAudio spec, the AudioBufferCallback interface
should not exist.  Instead we should have a DecodeSuccessCallback and
DecodeErrorCallback functions.

BUG=707338
TEST=none
==========

to

==========
Remove AudioBufferCallback

According to the WebAudio spec, the AudioBufferCallback interface
should not exist.  Instead we should have a DecodeSuccessCallback and
DecodeErrorCallback functions.

BUG=707338
TEST=callback behavior covered by existing tests
==========

[Raymond Toy, 2017-04-20 15:23:39]

rtoy@chromium.org changed reviewers:
+ tkent@chromium.org

[Raymond Toy, 2017-04-20 15:23:40]

tkent: PTAL as API Owner. Just a minor tweak to remove AudioBufferCallback. 
None of these were user-visible, so no intent was written.

[tkent, 2017-04-20 23:11:23]

lgtm

[Raymond Toy, 2017-04-21 14:56:53]

The CQ bit was checked by rtoy@chromium.org

[Raymond Toy, 2017-04-21 14:56:53]

The patchset sent to the CQ was uploaded after l-g-t-m from foolip@chromium.org,
hongchan@chromium.org
Link to the patchset: https://codereview.chromium.org/2820113006/#ps40001
(title: "Slightly reorder BaseAudioContext.idl")

[commit-bot: I haz the power, 2017-04-21 14:57:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-21 16:39:55]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1492786613049720,
"parent_rev": "eada5d80f2de49b9d397e8ee5c4df2f60e7582e9", "commit_rev":
"91e558ce715fc5990700cfd003084b6c4a8ed3fa"}

[commit-bot: I haz the power, 2017-04-21 16:40:05]

Description was changed from

==========
Remove AudioBufferCallback

According to the WebAudio spec, the AudioBufferCallback interface
should not exist.  Instead we should have a DecodeSuccessCallback and
DecodeErrorCallback functions.

BUG=707338
TEST=callback behavior covered by existing tests
==========

to

==========
Remove AudioBufferCallback

According to the WebAudio spec, the AudioBufferCallback interface
should not exist.  Instead we should have a DecodeSuccessCallback and
DecodeErrorCallback functions.

BUG=707338
TEST=callback behavior covered by existing tests

Review-Url: https://codereview.chromium.org/2820113006
Cr-Commit-Position: refs/heads/master@{#466363}
Committed:
https://chromium.googlesource.com/chromium/src/+/91e558ce715fc5990700cfd00308...
==========

[commit-bot: I haz the power, 2017-04-21 16:40:06]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/91e558ce715fc5990700cfd00308...