Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(835)

Unified Diff: third_party/WebKit/Source/modules/webaudio/BaseAudioContext.h

Issue 2820113006: Remove AudioBufferCallback (Closed)
Patch Set: Slightly reorder BaseAudioContext.idl Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/webaudio/BaseAudioContext.h
diff --git a/third_party/WebKit/Source/modules/webaudio/BaseAudioContext.h b/third_party/WebKit/Source/modules/webaudio/BaseAudioContext.h
index 67b43b01e3e292c0896759ba9b361679df712635..5f9c053e80d4e486bd62dded20a93ea6d5188399 100644
--- a/third_party/WebKit/Source/modules/webaudio/BaseAudioContext.h
+++ b/third_party/WebKit/Source/modules/webaudio/BaseAudioContext.h
@@ -51,7 +51,6 @@ namespace blink {
class AnalyserNode;
class AudioBuffer;
-class AudioBufferCallback;
class AudioBufferSourceNode;
class AudioContextOptions;
class AudioListener;
@@ -62,6 +61,8 @@ class ChannelSplitterNode;
class ConstantSourceNode;
class ConvolverNode;
class DelayNode;
+class DecodeErrorCallback;
+class DecodeSuccessCallback;
class Document;
class DynamicsCompressorNode;
class ExceptionState;
@@ -169,16 +170,25 @@ class MODULES_EXPORT BaseAudioContext
// Asynchronous audio file data decoding.
ScriptPromise decodeAudioData(ScriptState*,
DOMArrayBuffer* audio_data,
- AudioBufferCallback* success_callback,
- AudioBufferCallback* error_callback,
+ DecodeSuccessCallback*,
+ DecodeErrorCallback*,
+ ExceptionState&);
+
+ ScriptPromise decodeAudioData(ScriptState*,
+ DOMArrayBuffer* audio_data,
+ ExceptionState&);
+
+ ScriptPromise decodeAudioData(ScriptState*,
+ DOMArrayBuffer* audio_data,
+ DecodeSuccessCallback*,
ExceptionState&);
// Handles the promise and callbacks when |decodeAudioData| is finished
// decoding.
void HandleDecodeAudioData(AudioBuffer*,
ScriptPromiseResolver*,
- AudioBufferCallback* success_callback,
- AudioBufferCallback* error_callback);
+ DecodeSuccessCallback*,
+ DecodeErrorCallback*);
AudioListener* listener() { return listener_; }
« no previous file with comments | « third_party/WebKit/Source/modules/webaudio/BUILD.gn ('k') | third_party/WebKit/Source/modules/webaudio/BaseAudioContext.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698